Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bacula: fix build on aarch64-darwin #199269

Merged
merged 1 commit into from
Nov 6, 2022
Merged

bacula: fix build on aarch64-darwin #199269

merged 1 commit into from
Nov 6, 2022

Conversation

wegank
Copy link
Member

@wegank wegank commented Nov 3, 2022 •
edited
Loading

Description of changes

ZHF #199919.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Nov 3, 2022
@ofborg ofborg bot requested review from lovek323 and proteansec November 3, 2022 00:39
Atemu
Atemu reviewed Nov 3, 2022
View reviewed changes
Copy link
Member

@Atemu Atemu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Result of nixpkgs-review pr 199269 run on aarch64-darwin 1

1 package built:
  • bacula

Ran bacula status

pkgs/tools/backup/bacula/default.nix Show resolved Hide resolved
@wegank wegank force-pushed the bacula-aarch64-darwin branch from 2d23024 to 1ce5bfc Compare November 3, 2022 11:23
@wegank wegank requested a review from Atemu November 3, 2022 11:24
@marsam marsam merged commit 8f9f725 into NixOS:master Nov 6, 2022
@wegank wegank deleted the bacula-aarch64-darwin branch November 6, 2022 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Atemu Atemu Atemu approved these changes

@lovek323 lovek323 Awaiting requested review from lovek323

@proteansec proteansec Awaiting requested review from proteansec

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wegank @Atemu @marsam