-
-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
or-tools: add darwin support #201136
or-tools: add darwin support #201136
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Result of nixpkgs-review pr 201136
run on x86_64-darwin 1
3 packages failed to build:
- or-tools
- python310Packages.ortools
- python39Packages.ortools
96/394 Test #104: python_model_builder_assignment_mb .........................................***Failed 0.17 sec
Traceback (most recent call last):
File "/tmp/nix-build-or-tools-9.4.drv-0/source/ortools/model_builder/samples/assignment_mb.py", line 17, in <module>
from ortools.model_builder.python import model_builder
ModuleNotFoundError: No module named 'ortools.model_builder'
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/using-a-derivation-on-an-unsupported-platform/24131/2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Build passes on macOS 13.1, both aarch64-darwin and x86_64-darwin (via Rosetta).
@wegank not for me, still getting the same results as above. |
@ofborg build or-tools or-tools.passthru.tests |
Result of 3 packages built:
|
Result of 3 packages built:
|
Result of 3 packages built:
|
Description of changes
Add support for
or-tools
on Mac. Build was borked because of@rpath
issues in the generated dynlib and binaries used for testing (checkPhase
a lactest
). This works on my machine so sharing the changes with all.Some related discussion:
This also seems to me the lesser of two evils.
fixdarwindylibnames
exists but presents two problems, making it insufficient.checkPhase
, so I need to run it as thepostBuildHook
asctest
uses linked objects and fails to pass.dylib
files. This project creates a large amount of executables that do not get patched and are used byctest
. Again failing thecheckPhase
.Open to thoughts, I'm using it now and it functions well enough.
Things done
sandbox = true
set innix.conf
? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)nixos/doc/manual/md-to-db.sh
to update generated release notes