Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wasabiwallet: 2.0.1.3 -> 2.0.2 #202582

Merged
merged 2 commits into from
Nov 25, 2022
Merged

Conversation

mdarocha
Copy link
Contributor

Description of changes

https://github.com/zkSNACKs/WalletWasabi/releases/tag/v2.0.2

This release uses .NET 6 instead of .NET 5, which helps with #173115

I also had to change up the derivation a bit, since the previous package wasn't starting up for me, due to missing dependencies. I now generate a wrapper script which sets LD_LIBRARY_PATH, instead of trying to find and patch all binaries with patchelf.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@mdarocha mdarocha mentioned this pull request Nov 23, 2022
5 tasks
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Nov 23, 2022
@GGG-KILLER GGG-KILLER mentioned this pull request Nov 23, 2022
7 tasks
@mdarocha mdarocha force-pushed the wasabiwallet-update branch from 1069ea2 to 2819a7f Compare November 24, 2022 23:21
Also add a wrapper script that sets the proper environment variables,
instead of trying to find all executable binaries.
@mdarocha mdarocha force-pushed the wasabiwallet-update branch from 2819a7f to a21593d Compare November 25, 2022 02:57
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/1467

@github-actions
Copy link
Contributor

Successfully created backport PR #202809 for release-22.11.

@mdarocha mdarocha deleted the wasabiwallet-update branch November 25, 2022 09:25
@wegank wegank mentioned this pull request Jan 23, 2023
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants