Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixVersion.nix_{2_6,2_7,2_8,2_9}: remove #204481

Merged
merged 4 commits into from
Jan 6, 2023

Conversation

Artturin
Copy link
Member

@Artturin Artturin commented Dec 4, 2022

the comment from 2_6 does not apply anymore because the fix has been merged nix#7283
and the fix has been applied to 2_9+

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@Artturin Artturin mentioned this pull request Dec 4, 2022
13 tasks
@Artturin Artturin changed the title nixVersion.nix_{2_6,2_7,2_8}: remove nixVersion.nix_{2_6,2_7,2_8,2_9}: remove Dec 4, 2022
@Artturin Artturin mentioned this pull request Dec 4, 2022
13 tasks
@roberth
Copy link
Member

roberth commented Dec 5, 2022

fyi @domenkozar, this updates cachix's linked nix version 2.9 -> 2.10

@ofborg build cachix hercules-ci-agent hci

@bobby285271
Copy link
Member

bobby285271 commented Dec 5, 2022

@ofborg build packagekit

(This will block the channel via the gnome test. It should build with latest nix with PackageKit/PackageKit#551, but I will probably suggest that we disable the nix backend by default since nobody actually have time to investigate the rw issue 🙃)

the comment from 2_6 does not apply anymore because the fix has been
merged nix#7283
and the fix has been applied to 2_9+
@Artturin
Copy link
Member Author

@jtojnar @bobby285271 @roberth @domenkozar i wil merge this in 2 days

Result of nixpkgs-review pr 204481 run on x86_64-linux 1

13 packages built:
  • cachix
  • gnome.gnome-packagekit
  • gnome.gnome-software
  • gnome.simple-scan
  • hci
  • hercules-ci-agent
  • libsForQt5.discover
  • libsForQt5.packagekit-qt
  • packagekit
  • pantheon.appcenter
  • pantheon.elementary-onboarding
  • rnix-lsp
  • system-config-printer

@domenkozar domenkozar merged commit 9ff4f40 into NixOS:master Jan 6, 2023
@Artturin Artturin deleted the removenixvers1 branch June 12, 2023 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants