Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dotnet-sdk_3.1: 3.1.425 -> 3.1.426 #206765

Merged
merged 1 commit into from
Jan 6, 2023
Merged

dotnet-sdk_3.1: 3.1.425 -> 3.1.426 #206765

merged 1 commit into from
Jan 6, 2023

Conversation

JamieMagee
Copy link
Member

Description of changes

version update via update.sh

NOTE: .NET Core 3.1 is now EOL as of 13th December 2022 and should no longer be built, however I'd like to make this final update before making it throw.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@JamieMagee JamieMagee changed the title dotnet-sdk_3.1 3.1.425 -> 3.1.426 dotnet-sdk_3.1: 3.1.425 -> 3.1.426 Dec 18, 2022
@mdarocha
Copy link
Contributor

Note that you can't remove 3.1 without updating all packages that depend on it. This is tracked in #202572

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/1576

@JamieMagee
Copy link
Member Author

This contains a fix for CVE-2022-41089. See https://github.com/dotnet/core/blob/main/release-notes/3.1/3.1.32/3.1.32.md

@JamieMagee JamieMagee added the 1.severity: security Issues which raise a security issue, or PRs that fix one label Jan 3, 2023
risicle
risicle approved these changes Jan 6, 2023
View reviewed changes
Copy link
Contributor

@risicle risicle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nixpkgs-review happy, macos 10.15, nixos x86_64 & aarch64-linux

@risicle risicle merged commit 63ed4f9 into NixOS:master Jan 6, 2023
@JamieMagee JamieMagee deleted the dotnet-3.1 branch January 7, 2023 00:17
@JamieMagee JamieMagee mentioned this pull request Jan 7, 2023
Merged
13 tasks
@github-actions github-actions bot mentioned this pull request Jan 9, 2023
Merged
1 task
@github-actions
Copy link
Contributor

github-actions bot commented Jan 9, 2023

Successfully created backport PR #209813 for release-22.11.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdarocha mdarocha mdarocha approved these changes

@risicle risicle risicle approved these changes

@IvarWithoutBones IvarWithoutBones Awaiting requested review from IvarWithoutBones

Assignees
No one assigned
Labels
1.severity: security Issues which raise a security issue, or PRs that fix one 10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JamieMagee @mdarocha @nixos-discourse @risicle