Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rocm-related: implement more derivations #206995

Merged
merged 23 commits into from
Jan 19, 2023
Merged

rocm-related: implement more derivations #206995

merged 23 commits into from
Jan 19, 2023

Conversation

Madouura
Copy link
Contributor

@Madouura Madouura commented Dec 20, 2022 •
edited
Loading

Description of changes

Tracking: #197885
Last of the rocm packages with the exception of MIVisionX, atmi, and aomp.
Ignore the commits up to hipify: init at 5.4.1, they're just there to prevent a conflict until the next staging-next is merged into master. Then I'll rebase. staging-next has been merged.
closes #200479

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@Madouura Madouura mentioned this pull request Dec 20, 2022
Open
34 tasks
@Madouura
Copy link
Contributor Author

Madouura commented Dec 20, 2022 •
edited
Loading

Forgot to mention.
The python packages blaze and blaze-odo were a mistake, what I needed was 9d71aa1adcd7ceb32143a9c3ef9f6a69fb336333.
There was no reason to get rid of them though, so here they are.
Found a reason, they haven't been maintained since 2018.

@Madouura Madouura mentioned this pull request Dec 23, 2022
Closed
@Madouura Madouura force-pushed the pr/rocm-related branch 2 times, most recently from c261443 to 7a34f29 Compare December 25, 2022 06:34
@Madouura Madouura mentioned this pull request Dec 25, 2022
Closed
13 tasks
@ofborg ofborg bot added 8.has: clean-up 8.has: package (new) This PR adds a new package labels Dec 25, 2022
@Madouura
Copy link
Contributor Author

Madouura commented Dec 26, 2022 •
edited
Loading

Added the typing-extensions fix as it's own commit so it's easily revertible when it is fixed.
This isn't needed, I actually needed to add typing-extensions to PYTHONPATH.

@Madouura
Copy link
Contributor Author

And thankfully typing-extensions being in propagatedBuildInputs does make sure it's in PYTHONPATH, I'm just not sure what to do outside of nixpkgs... It's a pain to have to define PYTHONPATH and then call ${torch}/bin/torchrun...

@Madouura
Copy link
Contributor Author

Preliminary checks with a couple packages (torchvision and deepwave) seem to still work if torch is manually changed to torchWithRocm

@Madouura Madouura mentioned this pull request Dec 26, 2022
Merged
13 tasks
@Madouura
Copy link
Contributor Author

Madouura commented Dec 26, 2022 •
edited
Loading

The problems I've been having concerning typing-extensions are directly related to NixOS/nix#7512.

@ofborg ofborg bot requested a review from thoughtpolice January 15, 2023 11:56
@Madouura
Copy link
Contributor Author

I'm going to save strictDeps for another PR, it's going to be a lot of changing things it seems.

FRidh
FRidh requested changes Jan 18, 2023
View reviewed changes
Copy link
Member

@FRidh FRidh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to me aside from the one remark

pkgs/development/libraries/science/math/magma/default.nix Outdated Show resolved Hide resolved
@Madouura
magma: add rocm support
ef3daff
@Madouura
python3Packages: torch: add rocm support
e539c14
@Madouura
rocm-related: don't enable broken as long as minor version is the same
5141304
@Madouura
rocm-related: 5.4.1 → 5.4.2
18c8829 
hip-common: 5.4.1 → 5.4.2

hipblas: 5.4.1 → 5.4.2

hipcc: 5.4.1 → 5.4.2

hip: 5.4.1 → 5.4.2

hipfft: 5.4.1 → 5.4.2

hipcub: 5.4.1 → 5.4.2

hipify: 5.4.1 → 5.4.2

hipfort: 5.4.1 → 5.4.2

clang-ocl: 5.4.1 → 5.4.2

hipsolver: 5.4.1 → 5.4.2

llvmPackages_rocm.llvm: 5.4.1 → 5.4.2

migraphx: 5.4.1 → 5.4.2

miopen: 5.4.1 → 5.4.2

rdc: 5.4.1 → 5.4.2

rccl: 5.4.1 → 5.4.2

rocblas: 5.4.1 → 5.4.2

miopengemm: 5.4.1 → 5.4.2

hipsparse: 5.4.1 → 5.4.2

rocdbgapi: 5.4.1 → 5.4.2

rocfft: 5.4.1 → 5.4.2

rocgdb: 5.4.1 → 5.4.2

rocclr: 5.4.1 → 5.4.2

rocalution: 5.4.1 → 5.4.2

rocm-device-libs: 5.4.1 → 5.4.2

rocm-opencl-runtime: 5.4.1 → 5.4.2

rocm-cmake: 5.4.1 → 5.4.2

rocm-thunk: 5.4.1 → 5.4.2

rocminfo: 5.4.1 → 5.4.2

rocmlir: 5.4.0 → 5.4.1

rocm-comgr: 5.4.1 → 5.4.2

rocprofiler: 5.4.1 → 5.4.2

rocr-debug-agent: 5.4.1 → 5.4.2

rocrand: 5.4.1 → 5.4.2

rocsolver: 5.4.1 → 5.4.2

roctracer: 5.4.1 → 5.4.2

rocm-smi: 5.4.1 → 5.4.2

rocwmma: 5.4.1 → 5.4.2

rocprim: 5.4.1 → 5.4.2

rocsparse: 5.4.1 → 5.4.2

rocthrust: 5.4.1 → 5.4.2

tensile: 5.4.1 → 5.4.2
@Madouura
rocfft: restructure to allow hydra caching
731b7a0
@Madouura
rocfft: add rocrand to fix tests/benchmarks
455692a
@Madouura
composable_kernel: unstable-2022-12-15 → unstable-2023-01-16
3e81bf4
@Madouura
composable_kernel: restructure to allow hydra caching
c35b222
@Madouura
rocm-related: set platforms to linux
6e50207
@Madouura Madouura mentioned this pull request Jan 19, 2023
Closed
@FRidh FRidh merged commit 7cfe983 into NixOS:master Jan 19, 2023
@FRidh
Copy link
Member

FRidh commented Jan 19, 2023

Nice work, thanks!

@Madouura Madouura deleted the pr/rocm-related branch January 19, 2023 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mindavi Mindavi Mindavi left review comments

@Flakebi Flakebi Flakebi left review comments

@dali99 dali99 dali99 left review comments

@mweinelt mweinelt mweinelt left review comments

@SuperSandro2000 SuperSandro2000 SuperSandro2000 approved these changes

@FRidh FRidh FRidh approved these changes

@acowley acowley Awaiting requested review from acowley

@lovesegfault lovesegfault Awaiting requested review from lovesegfault

@bhipple bhipple Awaiting requested review from bhipple

@tbenst tbenst Awaiting requested review from tbenst

@alexarice alexarice Awaiting requested review from alexarice

@thoughtpolice thoughtpolice Awaiting requested review from thoughtpolice

@teh teh Awaiting requested review from teh

@tscholak tscholak Awaiting requested review from tscholak

@matthewbauer matthewbauer Awaiting requested review from matthewbauer

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
6.topic: python 8.has: clean-up 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 11-100 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@Madouura @FRidh @mweinelt @justinkb @dali99 @Flakebi @SuperSandro2000 @Mindavi