rust: fix on aarch64-linux by using GCC 11 and passing -lgcc
#209113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change switches to using GCC 11 by default on aarch64-linux, as well as passing `-lgcc` to the linker, per NixOS#201485. See NixOS#201254 and NixOS#208412 for wider context on the issue.
13 tasks
Mindavi
reviewed
Jan 5, 2023
|
Maybe we'll need something similar for |
13 tasks
vcunat
added a commit
that referenced
this pull request
Jan 13, 2023
All three versions are the same in this respect. It's the issue with old libgcc_s propagated via our glibc package; e.g. #209113
vcunat
added a commit
to vcunat/nixpkgs
that referenced
this pull request
Jan 15, 2023
It's the issue with old libgcc_s propagated via our glibc package; e.g. NixOS#209113
13 tasks
13 tasks
winterqt
pushed a commit
to winterqt/nixpkgs
that referenced
this pull request
Feb 15, 2023
All three versions are the same in this respect. It's the issue with old libgcc_s propagated via our glibc package; e.g. NixOS#209113 (cherry picked from commit 77a214e)
winterqt
pushed a commit
to winterqt/nixpkgs
that referenced
this pull request
Feb 15, 2023
It's the issue with old libgcc_s propagated via our glibc package; e.g. NixOS#209113 (cherry picked from commit cdf0283)
winterqt
added a commit
to winterqt/nixpkgs
that referenced
this pull request
Feb 15, 2023
See NixOS#209113 for context. This has to be done manually because rpm-ostree doesn't use the Cargo setup hooks (which automatically set this flag).
wegank
added a commit
to wegank/nixpkgs
that referenced
this pull request
Mar 1, 2023
This commit reverts NixOS#209113, since aarch64-linux now uses GCC 12 by default.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
This change switches to using GCC 11 by default on aarch64-linux, as well as passing
-lgccto the linker, per #201485.See #201254 and #208412 for wider context on the issue.
I'm opening this just so we have something to fall back on for the short-term in case #209063 has to be held back for whatever reason. As such, this is a draft, but just to prevent merging; I appreciate any and all reviews.
Things done
nix-build -A fdsandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes