-
-
Notifications
You must be signed in to change notification settings - Fork 16.5k
python3Packages.pyls-mypy: remove #209582
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I don't know what the usual procedure for obsoleting packages in favor of others is, but instead of outright removing the attribute, wouldn't it be better to add an error message telling people who use |
I added an alias with a note. |
needs a rebase, but otherwise LGTM. if you want to, you can add the nice and detailed explanation you wrote in the description (thanks for doing that btw) of this PR to the commit message. |
df0d715
to
62979ed
Compare
Rebased and added the explanation from the PR to the commit message |
Result of |
needs another rebase. presumably after the merge of #209585 |
[`pyls-mypy`](https://github.com/tomv564/pyls-mypy) depends on the deprecated [`palantir/python-language-server`](https://github.com/palantir/python-language-server). nixpkgs doesn't package the `palantir` version, instead we package [`microsoft/python-language-server`](https://github.com/microsoft/python-language-server). I don't know if they are interchangable, but regardless, `pyls-mypy`, `palantir/python-language-server`, and `microsoft/python-language-server` are all deprecated. The replacement for `palantir/python-language-server` and `microsoft/python-language-server` is [`python-lsp-server`](https://github.com/python-lsp/python-lsp-server) which is [already in nixpkgs](https://github.com/NixOS/nixpkgs/blob/master/pkgs/development/python-modules/python-lsp-server/default.nix). The replacement for `pyls-mypy` is [`pylsp-mypy`](https://github.com/python-lsp/pylsp-mypy) and [is also already available in nixpkgs](https://github.com/NixOS/nixpkgs/blob/master/pkgs/development/python-modules/pylsp-mypy/default.nix)
no merge commits please. I'll merge this after CI passes, if there aren't any objections. |
Description of changes
Remove
pyls-mypy
pyls-mypy
depends on the deprecatedpalantir/python-language-server
. nixpkgs doesn't package thepalantir
version, instead we packagemicrosoft/python-language-server
. I don't know if they are interchangable, but regardless,pyls-mypy
,palantir/python-language-server
, andmicrosoft/python-language-server
are all deprecated.The replacement for
palantir/python-language-server
andmicrosoft/python-language-server
ispython-lsp-server
which is already in nixpkgs. The replacement forpyls-mypy
ispylsp-mypy
and is also already available in nixpkgsRelated to #209585
Things done
sandbox = true
set innix.conf
? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)nixos/doc/manual/md-to-db.sh
to update generated release notes