Skip to content

python3Packages.pyls-mypy: remove #209582

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 16, 2023
Merged

python3Packages.pyls-mypy: remove #209582

merged 1 commit into from
Feb 16, 2023

Conversation

JamieMagee
Copy link
Member

@JamieMagee JamieMagee commented Jan 7, 2023

Description of changes

Remove pyls-mypy

pyls-mypy depends on the deprecated palantir/python-language-server. nixpkgs doesn't package the palantir version, instead we package microsoft/python-language-server. I don't know if they are interchangable, but regardless, pyls-mypy, palantir/python-language-server, and microsoft/python-language-server are all deprecated.

The replacement for palantir/python-language-server and microsoft/python-language-server is python-lsp-server which is already in nixpkgs. The replacement for pyls-mypy is pylsp-mypy and is also already available in nixpkgs

Related to #209585

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Jan 7, 2023
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Jan 7, 2023
@GGG-KILLER
Copy link
Contributor

I don't know what the usual procedure for obsoleting packages in favor of others is, but instead of outright removing the attribute, wouldn't it be better to add an error message telling people who use pyls-mypy to use pylsp-mypy instead?

@JamieMagee
Copy link
Member Author

I added an alias with a note.

@ajs124
Copy link
Member

ajs124 commented Feb 13, 2023

needs a rebase, but otherwise LGTM.

if you want to, you can add the nice and detailed explanation you wrote in the description (thanks for doing that btw) of this PR to the commit message.
that way, if someone finds the removal in the git history, they don't need to go to github to figure out the reasoning.

@JamieMagee
Copy link
Member Author

Rebased and added the explanation from the PR to the commit message

@JamieMagee
Copy link
Member Author

Result of nixpkgs-review pr 209582 run on x86_64-linux 1

@ajs124
Copy link
Member

ajs124 commented Feb 14, 2023

needs another rebase. presumably after the merge of #209585

[`pyls-mypy`](https://github.com/tomv564/pyls-mypy) depends on the deprecated [`palantir/python-language-server`](https://github.com/palantir/python-language-server). nixpkgs doesn't package the `palantir` version, instead we package [`microsoft/python-language-server`](https://github.com/microsoft/python-language-server). I don't know if they are interchangable, but regardless, `pyls-mypy`, `palantir/python-language-server`, and `microsoft/python-language-server` are all deprecated.

The replacement for `palantir/python-language-server` and `microsoft/python-language-server` is [`python-lsp-server`](https://github.com/python-lsp/python-lsp-server) which is [already in nixpkgs](https://github.com/NixOS/nixpkgs/blob/master/pkgs/development/python-modules/python-lsp-server/default.nix). The replacement for `pyls-mypy` is [`pylsp-mypy`](https://github.com/python-lsp/pylsp-mypy) and [is also already available in nixpkgs](https://github.com/NixOS/nixpkgs/blob/master/pkgs/development/python-modules/pylsp-mypy/default.nix)
@ajs124
Copy link
Member

ajs124 commented Feb 15, 2023

no merge commits please. I'll merge this after CI passes, if there aren't any objections.

@ajs124 ajs124 merged commit 6458170 into NixOS:master Feb 16, 2023
@JamieMagee JamieMagee deleted the pyls-mypy branch September 3, 2023 05:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants