Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sage: staging-next 2023-01-05 upgrade fixes #211390

Merged
merged 3 commits into from
Jan 18, 2023

Conversation

collares
Copy link
Member

@collares collares commented Jan 18, 2023

Description of changes

The last staging-next merge (#209180) caused a few test failures on Sage:

More detail on the last point: Some deprecation notices weren't being reported due to an upstream bug fixed in jupyter-widgets/ipywidgets#3569, and upstream is now in the process of fixing/suppressing the newly-discovered warnings (see the ChangeLog for some examples). Unfortunately I do not have time to investigate the specific problem in more detail right now.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Jan 18, 2023
@collares collares changed the title sage: matplotlib 3.6 upgrade fixes sage: staging-next upgrade fixes Jan 18, 2023
@collares collares force-pushed the sage-matplotlib-3.6 branch from 2e8181c to a89dae7 Compare January 18, 2023 14:56
@collares collares changed the title sage: staging-next upgrade fixes sage: staging-next 2023-01-05 upgrade fixes Jan 18, 2023
Copy link
Member

@timokau timokau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for staying on top of this, great work :)

@collares
Copy link
Member Author

Thank you for the review :)

@collares collares merged commit 44fc962 into NixOS:master Jan 18, 2023
@collares collares deleted the sage-matplotlib-3.6 branch January 18, 2023 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants