sage: staging-next 2023-01-05 upgrade fixes #211390
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
The last staging-next merge (#209180) caused a few test failures on Sage:
DeprecationWarning
due to widgets/interaction.py'son_submit
call jupyter-widgets/ipywidgets#3669. I have papered over it for the time being, but I will import an upstream patch from ipywidgets as soon as it is available.More detail on the last point: Some deprecation notices weren't being reported due to an upstream bug fixed in jupyter-widgets/ipywidgets#3569, and upstream is now in the process of fixing/suppressing the newly-discovered warnings (see the ChangeLog for some examples). Unfortunately I do not have time to investigate the specific problem in more detail right now.
Things done
sandbox = true
set innix.conf
? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)nixos/doc/manual/md-to-db.sh
to update generated release notes