Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rocm-related: fix hydra workarounds #213208

Merged
merged 2 commits into from
Jan 29, 2023
Merged

Conversation

Madouura
Copy link
Contributor

@Madouura Madouura commented Jan 28, 2023

Description of changes

Tracking: #197885
Hopefully this should eliminate all references to the base derivations.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@Madouura Madouura mentioned this pull request Jan 28, 2023
34 tasks
@ofborg ofborg bot requested a review from Flakebi January 28, 2023 19:36
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 labels Jan 28, 2023
@Madouura
Copy link
Contributor Author

Result of nixpkgs-review pr 213208 run on x86_64-linux 1

7 packages built:
  • composable_kernel
  • hipfft
  • migraphx
  • miopen (miopen-hip)
  • miopen-opencl
  • python310Packages.torchWithRocm
  • rocfft

@wegank wegank merged commit af84875 into NixOS:master Jan 29, 2023
@Madouura Madouura deleted the pr/rocm-hydra branch January 29, 2023 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants