-
-
Notifications
You must be signed in to change notification settings - Fork 14.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ncurses: Create libtinfo symlink #21350
Conversation
@spacekitteh, thanks for your PR! By analyzing the history of the files in this pull request, we identified @edolstra, @wkennington and @vcunat to be potential reviewers. |
Well it works |
Some applications expect libtinfo to be a separate library to libncurses; this fixes that.
b8a3a74
to
70424e1
Compare
@vcunat staging? |
(travis errord out 'cus of log length) |
I understand that "Some programs", in your case, means AOSP. Have you tested that the AOSP works for you with this patch? Because I can see that you tested that the patch does not break things, but I don't know if it fixes your problems with AOSP. |
It fixes one of many problems |
Does this change stdenv? |
I don't believe so, no. At least, it fetches stdenv rather than building it. |
I tested that it does not change stdenv. Good. |
It doesn't rebuild stdenv but it causes ~~10k job rebuilds just on x86_64-linux, which feels large enough to me. |
gdi |
This reverts commit 0c13820. Moved to staging.
Moved. |
The worst thing now is that such builds would have to be performed twice - once for master and again in staging (due to other mass-rebuild changes in there). |
Ah ok. Fine! |
This was originally added in NixOS#21350 best to use this name for clarity.
This was originally added in NixOS#21350 best to use this name for clarity. (cherry picked from commit 4c85aba)
Some applications expect libtinfo to be a separate library to libncurses; this fixes that.
Fedora's workaround which does the same thing: commercialhaskell/stack#1012 (comment)
Arch's: https://aur.archlinux.org/packages/ncurses5-compat-libs/
Gentoo example: https://forums.gentoo.org/viewtopic-t-996220-start-0.html
Motivation for this change
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandbox
innix.conf
on non-NixOS)
nix-shell -p nox --run "nox-review wip"
./result/bin/
)