Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ncurses: Create libtinfo symlink #21350

Merged
merged 1 commit into from
Dec 22, 2016
Merged

ncurses: Create libtinfo symlink #21350

merged 1 commit into from
Dec 22, 2016

Conversation

spacekitteh
Copy link
Contributor

@spacekitteh spacekitteh commented Dec 22, 2016

Some applications expect libtinfo to be a separate library to libncurses; this fixes that.

Fedora's workaround which does the same thing: commercialhaskell/stack#1012 (comment)

Arch's: https://aur.archlinux.org/packages/ncurses5-compat-libs/

Gentoo example: https://forums.gentoo.org/viewtopic-t-996220-start-0.html

Motivation for this change
Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@spacekitteh, thanks for your PR! By analyzing the history of the files in this pull request, we identified @edolstra, @wkennington and @vcunat to be potential reviewers.

@spacekitteh
Copy link
Contributor Author

Well it works

Some applications expect libtinfo to be a separate library to libncurses; this fixes that.
@spacekitteh
Copy link
Contributor Author

@vcunat staging?

@spacekitteh
Copy link
Contributor Author

(travis errord out 'cus of log length)

@viric
Copy link
Member

viric commented Dec 22, 2016

I understand that "Some programs", in your case, means AOSP. Have you tested that the AOSP works for you with this patch? Because I can see that you tested that the patch does not break things, but I don't know if it fixes your problems with AOSP.

@spacekitteh
Copy link
Contributor Author

spacekitteh commented Dec 22, 2016

It fixes one of many problems

@viric
Copy link
Member

viric commented Dec 22, 2016

Does this change stdenv?

@spacekitteh
Copy link
Contributor Author

I don't believe so, no. At least, it fetches stdenv rather than building it.

@viric
Copy link
Member

viric commented Dec 22, 2016

I tested that it does not change stdenv. Good.

@viric viric merged commit 81f2e4f into NixOS:master Dec 22, 2016
@spacekitteh spacekitteh deleted the patch-23 branch December 22, 2016 10:10
@vcunat
Copy link
Member

vcunat commented Dec 22, 2016

It doesn't rebuild stdenv but it causes ~~10k job rebuilds just on x86_64-linux, which feels large enough to me.

@spacekitteh spacekitteh restored the patch-23 branch December 22, 2016 10:26
@spacekitteh
Copy link
Contributor Author

gdi

vcunat added a commit that referenced this pull request Dec 22, 2016
This reverts commit 81f2e4f, reversing
changes made to ebe19f5.
Moving to staging.
vcunat added a commit that referenced this pull request Dec 22, 2016
@vcunat
Copy link
Member

vcunat commented Dec 22, 2016

Moved.

@vcunat
Copy link
Member

vcunat commented Dec 22, 2016

The worst thing now is that such builds would have to be performed twice - once for master and again in staging (due to other mass-rebuild changes in there).

@spacekitteh spacekitteh deleted the patch-23 branch December 22, 2016 10:35
@viric
Copy link
Member

viric commented Dec 22, 2016

Ah ok. Fine!

matthewbauer added a commit to matthewbauer/nixpkgs that referenced this pull request Sep 18, 2019
This was originally added in

NixOS#21350

best to use this name for clarity.
dtzWill pushed a commit to dtzWill/nixpkgs that referenced this pull request Sep 21, 2019
This was originally added in

NixOS#21350

best to use this name for clarity.

(cherry picked from commit 4c85aba)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants