Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

schildichat-{web,desktop}: 1.11.13-sc.1 -> 1.11.22-sc.1 #214053

Merged
merged 2 commits into from
Feb 3, 2023
Merged

schildichat-{web,desktop}: 1.11.13-sc.1 -> 1.11.22-sc.1 #214053

merged 2 commits into from
Feb 3, 2023

Conversation

yu-re-ka
Copy link
Contributor

@yu-re-ka yu-re-ka commented Feb 1, 2023

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@yu-re-ka yu-re-ka requested review from Ma27 and yayayayaka February 1, 2023 21:37
@wegank wegank marked this pull request as draft February 1, 2023 22:33
@ofborg ofborg bot added the 11.by: package-maintainer This PR was created by the maintainer of the package it changes label Feb 1, 2023
@yu-re-ka yu-re-ka marked this pull request as ready for review February 2, 2023 13:47
@yayayayaka
Copy link
Member

Result of nixpkgs-review pr 214053 run on x86_64-linux 1

3 packages built:
  • schildichat-desktop
  • schildichat-desktop-wayland
  • schildichat-web

@yu-re-ka yu-re-ka requested a review from wegank February 2, 2023 13:48
Copy link
Member

@yayayayaka yayayayaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested schildichat-desktop on x86_64-linux. I had to reindex my messages for the encrypted message search functionality, but it works fine after that.

2023-02-02T13:49:18+01:00

@yu-re-ka
Copy link
Contributor Author

yu-re-ka commented Feb 3, 2023

I had to reindex my messages for the encrypted message search functionality, but it works fine after that.

I believe because you tested with a secondary profile, it could be this change: element-hq/element-desktop#433

I did not have to reindex in my main profile.

@yu-re-ka yu-re-ka merged commit f97172b into NixOS:master Feb 3, 2023
@yu-re-ka yu-re-ka deleted the schildichat-1-11-22 branch February 3, 2023 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants