Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

darwin.apple_sdk_11_0.rustPlatform: init #214119

Merged
merged 2 commits into from
Feb 2, 2023
Merged

Conversation

wegank
Copy link
Member

@wegank wegank commented Feb 2, 2023

Description of changes

This PR makes it easy to build Rust applications using macOS 11 SDK on x86_64-darwin.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Feb 2, 2023
@zowoq
Copy link
Contributor

zowoq commented Feb 2, 2023

cc @reckenrode @toonn @NixOS/rust

This PR makes it easy to build Rust applications using macOS 11 SDK on x86_64-darwin.

Could you include a package in this PR for testing please?

@ofborg ofborg bot added 10.rebuild-darwin: 1-10 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Feb 2, 2023
@wegank
Copy link
Member Author

wegank commented Feb 2, 2023

Added bupstash, which now passes on ofborg.

@figsoda
Copy link
Member

figsoda commented Feb 2, 2023

Result of nixpkgs-review pr 214119 run on x86_64-darwin 1

1 package marked as broken and skipped:
  • wizer
1 package failed to build:
  • qdrant
7 packages built:
  • bupstash
  • cargo-ui
  • kind2
  • lighthouse
  • procs
  • stork
  • wezterm

Copy link
Contributor

@reckenrode reckenrode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@winterqt winterqt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@winterqt winterqt merged commit 9918d59 into NixOS:master Feb 2, 2023
@wegank wegank deleted the rust-sdk-11-pre branch February 2, 2023 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 1-10 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants