golangci-lint: build with go1.20

[aaronjheng]

Description of changes

golangci/golangci-lint#3538

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 23.05 Release Notes (or backporting 22.11 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
  • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
• Fits CONTRIBUTING.md.

[wegank]

What is the advantage of moving to Go 1.20?

[aaronjheng]

see Description of changes.

[wegank]

A package being recently compatible with Go 1.20 doesn't seem to me a good reason to migrate to it. The package works fine on Go 1.19, right?

[aaronjheng]

golangci-lint-1.51.0 built with go1.19 does not work on go1.20.

[aaronjheng]

My bad. It turns out I tested with old version of golangci-lint accidentally. golangci-lint-1.51.0 built with go1.19 works fine.

[trevorwhitney]

I ran into something similar with golangci-lint-1.51.2. If using go 1.20, you must also build golangci-lint with 1.20. The default package from nixpkgs is built against go 1.19, and results in unbound memory usage if using go 1.20: golangci/golangci-lint#3582