Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SDL2_image: 2.0.5 -> 2.6.3 #215200

Merged
merged 3 commits into from
Feb 8, 2023
Merged

SDL2_image: 2.0.5 -> 2.6.3 #215200

merged 3 commits into from
Feb 8, 2023

Conversation

superherointj
Copy link
Contributor

@superherointj superherointj commented Feb 7, 2023 •
edited
Loading

Fixes #187685

Release: https://github.com/libsdl-org/SDL_image/releases/tag/release-2.6.3

This PR is ready to be reviewed/merged.

@ofborg ofborg bot requested a review from cpages February 7, 2023 23:11
@wegank
Copy link
Member

wegank commented Feb 8, 2023

@ofborg build python310Packages.pygame

@superherointj superherointj marked this pull request as draft February 8, 2023 09:27
@github-actions github-actions bot added 6.topic: haskell 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: printing 6.topic: python 6.topic: qt/kde 6.topic: vscode 8.has: changelog 8.has: documentation This PR adds or changes documentation 8.has: module (update) This PR changes an existing module in `nixos/` labels Feb 8, 2023
@superherointj superherointj changed the base branch from staging to master February 8, 2023 09:34
@github-actions github-actions bot removed 6.topic: printing 8.has: documentation This PR adds or changes documentation 6.topic: haskell 8.has: module (update) This PR changes an existing module in `nixos/` 6.topic: qt/kde 8.has: changelog 6.topic: vscode 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS labels Feb 8, 2023
@superherointj superherointj marked this pull request as ready for review February 8, 2023 09:40
@ofborg ofborg bot added 2.status: merge conflict This PR has merge conflicts with the target branch and removed 2.status: merge conflict This PR has merge conflicts with the target branch labels Feb 8, 2023
@ofborg ofborg bot requested a review from emilytrau February 8, 2023 09:49
@superherointj
Copy link
Contributor Author

@ofborg build python310Packages.pygame

@superherointj
Copy link
Contributor Author

superherointj commented Feb 8, 2023 •
edited
Loading

Result of nixpkgs-review pr 215200 run on x86_64-linux 1

2 packages marked as broken and skipped:
  • aqemu
  • python310Packages.rl-coach
1 package blacklisted:
  • appimage-run-tests
15 packages failed to build:
  • toppler (fixed by pinning to older version)
  • cot (python310Packages.cot, python311Packages.cot) => Fixed at python311Packages.cot: skip failing tests #215329
  • d1x-rebirth-full (requireFile)
  • d2x-rebirth-full (requireFile)
  • koboredux (requireFile)
  • pureref (requireFile)
  • python311Packages.pygame (cython problem, unrelated)
  • python311Packages.pygame-gui (depends on pygame)
  • python311Packages.pyrect (depends on pygame)
  • python311Packages.pygetwindow (depends on pyrect)
  • python311Packages.pyautogui (depends on pygetwindow)
  • python311Packages.pytmx (depends on pygame)
  • solo5 (fails at master, unrelated)
  • ocamlPackages.ocaml-freestanding (depends on solo5)
238 packages built:
  • SDL2_image
  • Sylk
  • _20kly
  • abbaye-des-morts
  • alephone
  • alephone-durandal
  • alephone-eternal
  • alephone-evil
  • alephone-infinity
  • alephone-marathon
  • alephone-pathways-into-darkness
  • alephone-pheonix
  • alephone-red
  • alephone-rubicon-x
  • alpine-make-vm-image
  • altair
  • anbox
  • anki-bin
  • anytype
  • appimage-run
  • assaultcube
  • beekeeper-studio
  • betterdiscord-installer
  • blobby
  • blobwars
  • blockattack
  • bloomrpc
  • bootstrap-studio
  • brutalmaze
  • buttercup-desktop
  • caprine-bin
  • cataclysm-dda
  • cataclysm-dda-git
  • cdogs-sdl
  • chromium-bsu
  • chrysalis
  • cider
  • cloud-init
  • cloud-utils
  • colima
  • colobot
  • commandergenius
  • cozy-drive
  • crawlTiles
  • crypto-org-wallet
  • devdocs-desktop
  • devilutionx
  • diffoscope
  • dxx-rebirth
  • electron-mail
  • electronplayer
  • endgame-singularity
  • enigma
  • fheroes2
  • firefly-desktop
  • flare
  • flexoptix-app
  • fluent-reader
  • framesh
  • freeciv
  • freeciv_qt
  • freeciv_sdl2
  • freenukum
  • frescobaldi
  • frogatto
  • fspy
  • gnome.gnome-boxes
  • gource
  • guestfs-tools
  • guile-sdl2
  • hedgewars
  • hikounomizu
  • infra-arcana
  • instead
  • instead-launcher
  • irccloud
  • joplin-desktop
  • keeperrl
  • keet
  • klystrack
  • koboredux-free
  • kodiPackages.steam-launcher
  • lbreakouthd
  • lbry
  • ldtk
  • ledger-live-desktop
  • lens
  • libguestfs
  • libguestfs-with-appliance
  • libresprite
  • lima
  • lima-bin
  • lincity_ng
  • linthesia
  • linuxKernel.packages.linux_4_14.virtualbox
  • linuxKernel.packages.linux_4_14_hardened.virtualbox
  • linuxKernel.packages.linux_4_19.virtualbox
  • linuxKernel.packages.linux_4_19_hardened.virtualbox
  • linuxKernel.packages.linux_5_10.virtualbox
  • linuxKernel.packages.linux_5_10_hardened.virtualbox
  • linuxKernel.packages.linux_5_15.virtualbox
  • linuxKernel.packages.linux_hardened.virtualbox (linuxKernel.packages.linux_5_15_hardened.virtualbox)
  • linuxKernel.packages.linux_5_4.virtualbox
  • linuxKernel.packages.linux_6_1.virtualbox
  • linuxKernel.packages.linux_6_1_hardened.virtualbox
  • linuxKernel.packages.linux_latest_libre.virtualbox
  • linuxKernel.packages.linux_libre.virtualbox
  • linuxKernel.packages.linux_lqx.virtualbox
  • linuxKernel.packages.linux_testing_bcachefs.virtualbox
  • linuxKernel.packages.linux_xanmod.virtualbox
  • linuxKernel.packages.linux_xanmod_latest.virtualbox (linuxKernel.packages.linux_xanmod_stable.virtualbox)
  • linuxKernel.packages.linux_zen.virtualbox
  • liquidsoap
  • logseq
  • logstalgia
  • losslesscut-bin
  • lpairs2
  • lunar-client
  • lutris
  • manaplus
  • marktext
  • mathpix-snipping-tool
  • mendeley
  • mepo
  • methane
  • minigalaxy
  • mobilecoin-wallet
  • molotov
  • motrix
  • multipass
  • museeks
  • mycrypto
  • neo4j-desktop
  • notable
  • notion-app-enhanced
  • nsz (python310Packages.nsz)
  • nuclear
  • ocamlPackages.tsdl-image
  • octant-desktop
  • open-watcom-bin
  • open-watcom-bin-unwrapped
  • opendune
  • openmsx
  • openspades
  • osu-lazer-bin
  • out-of-tree
  • p3x-onenote
  • passky-desktop
  • picoloop
  • pingus
  • pioneer
  • playonlinux
  • plexamp
  • polypane
  • prboom-plus
  • protontricks
  • pysolfc
  • python310Packages.guestfs
  • python310Packages.kivy
  • python310Packages.pyautogui
  • python310Packages.pygame
  • python310Packages.pygame-gui
  • python310Packages.pygame_sdl2
  • python310Packages.pygetwindow
  • python310Packages.pyrect
  • python310Packages.pysdl2
  • python310Packages.pytmx
  • python311Packages.guestfs
  • python311Packages.kivy
  • python311Packages.nsz
  • python311Packages.pygame_sdl2
  • python311Packages.pysdl2
  • qemu
  • qemu-utils
  • qemu_full
  • qemu_kvm
  • qtemu
  • quickemu
  • radicle-upstream
  • rambox
  • raven-reader
  • redeclipse
  • remnote
  • renpy
  • rocksndiamonds
  • saleae-logic-2
  • sauerbraten
  • sdlpop
  • session-desktop
  • solarus
  • solarus-quest-editor
  • sonixd
  • ssb-patchwork
  • standardnotes
  • station
  • steam
  • steam-rom-manager
  • steam-run
  • steam-tui
  • steamcmd
  • steamos-devkit
  • superTux
  • tauon
  • the-legend-of-edgar
  • timeular
  • tome4
  • trackballs
  • trezor-suite
  • trigger
  • tusk
  • uhk-agent
  • uhk-udev-rules
  • ultrastardx
  • unityhub
  • vagrant
  • vcmi
  • vdrift
  • vdrift-bin
  • via
  • vial
  • video2midi
  • virtualbox
  • virtualboxHardened
  • virtualboxHeadless
  • virtualboxWithExtpack
  • wargus
  • wesnoth
  • widelands
  • wootility
  • wpsoffice
  • wpsoffice-cn
  • xivlauncher
  • youtube-music
  • ytmdesktop
  • zecwallet-lite
  • zettlr
  • zpool-auto-expand-partitions
  • zulip

Unrelated problems:

Everything seems handled.

@superherointj
Copy link
Contributor Author

Handled all issues (so far). Feel free to review/merge.

@superherointj
Copy link
Contributor Author

superherointj commented Feb 8, 2023 •
edited
Loading

Result of nixpkgs-review pr 215200 run on x86_64-linux 1

2 packages marked as broken and skipped:
  • aqemu
  • python310Packages.rl-coach
1 package blacklisted:
  • appimage-run-tests
14 packages failed to build:
  • cot (python310Packages.cot), python311Packages.cot => Fixed at python311Packages.cot: skip failing tests #215329
  • d1x-rebirth-full, d2x-rebirth-full => requireFile
  • koboredux
  • pureref
  • python311Packages.pyautogui
  • python311Packages.pygame
  • python311Packages.pygame-gui
  • python311Packages.pygetwindow
  • python311Packages.pyrect
  • python311Packages.pytmx
  • solo5
  • ocamlPackages.ocaml-freestanding
239 packages built:
  • SDL2_image
  • SDL2_image_2_0_5
  • Sylk
  • _20kly
  • abbaye-des-morts
  • alephone
  • alephone-durandal
  • alephone-eternal
  • alephone-evil
  • alephone-infinity
  • alephone-marathon
  • alephone-pathways-into-darkness
  • alephone-pheonix
  • alephone-red
  • alephone-rubicon-x
  • alpine-make-vm-image
  • altair
  • anbox
  • anki-bin
  • anytype
  • appimage-run
  • assaultcube
  • beekeeper-studio
  • betterdiscord-installer
  • blobby
  • blobwars
  • blockattack
  • bloomrpc
  • bootstrap-studio
  • brutalmaze
  • buttercup-desktop
  • caprine-bin
  • cataclysm-dda
  • cataclysm-dda-git
  • cdogs-sdl
  • chromium-bsu
  • chrysalis
  • cider
  • cloud-init
  • cloud-utils
  • colima
  • colobot
  • commandergenius
  • cozy-drive
  • crawlTiles
  • crypto-org-wallet
  • devdocs-desktop
  • devilutionx
  • diffoscope
  • dxx-rebirth
  • electron-mail
  • electronplayer
  • endgame-singularity
  • enigma
  • fheroes2
  • firefly-desktop
  • flare
  • flexoptix-app
  • fluent-reader
  • framesh
  • freeciv
  • freeciv_qt
  • freeciv_sdl2
  • freenukum
  • frescobaldi
  • frogatto
  • fspy
  • gnome.gnome-boxes
  • gource
  • guestfs-tools
  • guile-sdl2
  • hedgewars
  • hikounomizu
  • infra-arcana
  • instead
  • instead-launcher
  • irccloud
  • joplin-desktop
  • keeperrl
  • keet
  • klystrack
  • koboredux-free
  • kodiPackages.steam-launcher
  • lbreakouthd
  • lbry
  • ldtk
  • ledger-live-desktop
  • lens
  • libguestfs
  • libguestfs-with-appliance
  • libresprite
  • lima
  • lima-bin
  • lincity_ng
  • linthesia
  • linuxKernel.packages.linux_4_14.virtualbox
  • linuxKernel.packages.linux_4_14_hardened.virtualbox
  • linuxKernel.packages.linux_4_19.virtualbox
  • linuxKernel.packages.linux_4_19_hardened.virtualbox
  • linuxKernel.packages.linux_5_10.virtualbox
  • linuxKernel.packages.linux_5_10_hardened.virtualbox
  • linuxKernel.packages.linux_5_15.virtualbox
  • linuxKernel.packages.linux_hardened.virtualbox (linuxKernel.packages.linux_5_15_hardened.virtualbox)
  • linuxKernel.packages.linux_5_4.virtualbox
  • linuxKernel.packages.linux_6_1.virtualbox
  • linuxKernel.packages.linux_6_1_hardened.virtualbox
  • linuxKernel.packages.linux_latest_libre.virtualbox
  • linuxKernel.packages.linux_libre.virtualbox
  • linuxKernel.packages.linux_lqx.virtualbox
  • linuxKernel.packages.linux_testing_bcachefs.virtualbox
  • linuxKernel.packages.linux_xanmod.virtualbox
  • linuxKernel.packages.linux_xanmod_latest.virtualbox (linuxKernel.packages.linux_xanmod_stable.virtualbox)
  • linuxKernel.packages.linux_zen.virtualbox
  • liquidsoap
  • logseq
  • logstalgia
  • losslesscut-bin
  • lpairs2
  • lunar-client
  • lutris
  • manaplus
  • marktext
  • mathpix-snipping-tool
  • mendeley
  • mepo
  • methane
  • minigalaxy
  • mobilecoin-wallet
  • molotov
  • motrix
  • multipass
  • museeks
  • mycrypto
  • neo4j-desktop
  • notable
  • notion-app-enhanced
  • nsz (python310Packages.nsz)
  • nuclear
  • ocamlPackages.tsdl-image
  • octant-desktop
  • open-watcom-bin
  • open-watcom-bin-unwrapped
  • opendune
  • openmsx
  • openspades
  • osu-lazer-bin
  • out-of-tree
  • p3x-onenote
  • passky-desktop
  • picoloop
  • pingus
  • pioneer
  • playonlinux
  • plexamp
  • polypane
  • prboom-plus
  • protontricks
  • pysolfc
  • python310Packages.guestfs
  • python310Packages.kivy
  • python310Packages.pyautogui
  • python310Packages.pygame
  • python310Packages.pygame-gui
  • python310Packages.pygame_sdl2
  • python310Packages.pygetwindow
  • python310Packages.pyrect
  • python310Packages.pysdl2
  • python310Packages.pytmx
  • python311Packages.guestfs
  • python311Packages.kivy
  • python311Packages.nsz
  • python311Packages.pygame_sdl2
  • python311Packages.pysdl2
  • qemu
  • qemu-utils
  • qemu_full
  • qemu_kvm
  • qtemu
  • quickemu
  • radicle-upstream
  • rambox
  • raven-reader
  • redeclipse
  • remnote
  • renpy
  • rocksndiamonds
  • saleae-logic-2
  • sauerbraten
  • sdlpop
  • session-desktop
  • solarus
  • solarus-quest-editor
  • sonixd
  • ssb-patchwork
  • standardnotes
  • station
  • steam
  • steam-rom-manager
  • steam-run
  • steam-tui
  • steamcmd
  • steamos-devkit
  • superTux
  • tauon
  • the-legend-of-edgar
  • timeular
  • tome4
  • trackballs
  • trezor-suite
  • trigger
  • tusk
  • uhk-agent
  • uhk-udev-rules
  • ultrastardx
  • unityhub
  • vagrant
  • vcmi
  • vdrift
  • vdrift-bin
  • via
  • vial
  • video2midi
  • virtualbox
  • virtualboxHardened
  • virtualboxHeadless
  • virtualboxWithExtpack
  • wargus
  • wesnoth
  • widelands
  • wootility
  • wpsoffice
  • wpsoffice-cn
  • xivlauncher
  • youtube-music
  • ytmdesktop
  • zecwallet-lite
  • zettlr
  • zpool-auto-expand-partitions
  • zulip

@ofborg ofborg bot added the 8.has: package (new) This PR adds a new package label Feb 8, 2023
PedroHLC
PedroHLC reviewed Feb 8, 2023
View reviewed changes
pkgs/development/python-modules/pygame/default.nix Outdated Show resolved Hide resolved
pkgs/games/toppler/default.nix Outdated Show resolved Hide resolved
PedroHLC
PedroHLC approved these changes Feb 8, 2023
View reviewed changes
Copy link
Member

@PedroHLC PedroHLC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff LGTM

@PedroHLC PedroHLC added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Feb 8, 2023
@superherointj superherointj mentioned this pull request Feb 8, 2023
Closed
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/827

@superherointj superherointj merged commit 09d198f into NixOS:master Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PedroHLC PedroHLC PedroHLC approved these changes

@cpages cpages Awaiting requested review from cpages

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@emilytrau emilytrau Awaiting requested review from emilytrau

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 11-100 10.rebuild-linux: 101-500 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@superherointj @wegank @nixos-discourse @PedroHLC