pdal: 2.4.3 -> 2.5.4

[r-ryantm]

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/PDAL/PDAL/releases.

meta.description for pdal is: PDAL is Point Data Abstraction Library. GDAL for point cloud data

meta.homepage for pdal is: https://pdal.io

Updates performed

• Version update

To inspect upstream changes

• Release on GitHub

• Compare changes on GitHub

Impact

Checks done (click to expand)

---

• built on NixOS
• The tests defined in passthru.tests, if any, passed
• found 2.5.1 with grep in /nix/store/wcawlx3mf1zpvq1425s1r4vl7hnwn64g-pdal-2.5.1
• found 2.5.1 in filename of file in /nix/store/wcawlx3mf1zpvq1425s1r4vl7hnwn64g-pdal-2.5.1

---

Rebuild report (if merged into master) (click to expand)

6 total rebuild path(s)

6 package rebuild(s)

First fifty rebuilds by attrpath
cloudcompare
entwine
grass
pdal
qgis
qgis-ltr

Instructions to test this update (click to expand)

---

Either download from Cachix:

nix-store -r /nix/store/wcawlx3mf1zpvq1425s1r4vl7hnwn64g-pdal-2.5.1 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.

Or, build yourself:

nix-build -A pdal https://github.com/r-ryantm/nixpkgs/archive/1c7bcfd71ef8f8418a565d14b68d36653c6a7969.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:

ls -la /nix/store/wcawlx3mf1zpvq1425s1r4vl7hnwn64g-pdal-2.5.1
ls -la /nix/store/wcawlx3mf1zpvq1425s1r4vl7hnwn64g-pdal-2.5.1/bin

---

Pre-merge build results

We have automatically built all packages that will get rebuilt due to
this change.

This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.

Result of nixpkgs-review run on x86_64-linux 1

4 packages failed to build:

• entwine
• grass
• qgis
• qgis-ltr

2 packages built:

• cloudcompare
• pdal

---

Maintainer pings

cc @nh2 for testing.

[r-ryantm]

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/pdal/versions.

meta.description for pdal is: PDAL is Point Data Abstraction Library. GDAL for point cloud data

meta.homepage for pdal is: https://pdal.io

Updates performed

• Version update

To inspect upstream changes

• Release on GitHub

• Compare changes on GitHub

Impact

Checks done (click to expand)

---

• built on NixOS
• The tests defined in passthru.tests, if any, passed
• found 2.5.2 with grep in /nix/store/8d7ri85m5v6sr6jjpg4alqaybg4gj8as-pdal-2.5.2
• found 2.5.2 in filename of file in /nix/store/8d7ri85m5v6sr6jjpg4alqaybg4gj8as-pdal-2.5.2

---

Rebuild report (if merged into master) (click to expand)

6 total rebuild path(s)

6 package rebuild(s)

First fifty rebuilds by attrpath
cloudcompare
entwine
grass
pdal
qgis
qgis-ltr

Instructions to test this update (click to expand)

---

Either download from Cachix:

nix-store -r /nix/store/8d7ri85m5v6sr6jjpg4alqaybg4gj8as-pdal-2.5.2 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.

Or, build yourself:

nix-build -A pdal https://github.com/r-ryantm/nixpkgs/archive/b8d33da08a61594499d361364605a399a5b46d3c.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:

ls -la /nix/store/8d7ri85m5v6sr6jjpg4alqaybg4gj8as-pdal-2.5.2
ls -la /nix/store/8d7ri85m5v6sr6jjpg4alqaybg4gj8as-pdal-2.5.2/bin

---

Pre-merge build results

We have automatically built all packages that will get rebuilt due to
this change.

This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.

nixpkgs-review took longer than 45m and timed out

---

Maintainer pings

cc @nh2 for testing.

[r-ryantm]

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/PDAL/PDAL/releases.

meta.description for pdal is: PDAL is Point Data Abstraction Library. GDAL for point cloud data

meta.homepage for pdal is: https://pdal.io

Updates performed

• Version update

To inspect upstream changes

• Release on GitHub

• Compare changes on GitHub

Impact

Checks done (click to expand)

---

• built on NixOS
• The tests defined in passthru.tests, if any, passed
• found 2.5.3 with grep in /nix/store/g3zba82780xvn9qyipzb62wfrj4zdmap-pdal-2.5.3
• found 2.5.3 in filename of file in /nix/store/g3zba82780xvn9qyipzb62wfrj4zdmap-pdal-2.5.3

---

Rebuild report (if merged into master) (click to expand)

6 total rebuild path(s)

6 package rebuild(s)

First fifty rebuilds by attrpath
cloudcompare
entwine
grass
pdal
qgis
qgis-ltr

Instructions to test this update (click to expand)

---

Either download from Cachix:

nix-store -r /nix/store/g3zba82780xvn9qyipzb62wfrj4zdmap-pdal-2.5.3 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.

Or, build yourself:

nix-build -A pdal https://github.com/r-ryantm/nixpkgs/archive/cfae8abfc0b06ac792b06171365b0e42fb474485.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:

ls -la /nix/store/g3zba82780xvn9qyipzb62wfrj4zdmap-pdal-2.5.3
ls -la /nix/store/g3zba82780xvn9qyipzb62wfrj4zdmap-pdal-2.5.3/bin

---

Pre-merge build results

We have automatically built all packages that will get rebuilt due to
this change.

This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.

nixpkgs-review took longer than 45m and timed out

---

Maintainer pings

cc @nh2 for testing.

[r-ryantm]

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/PDAL/PDAL/releases.

meta.description for pdal is: PDAL is Point Data Abstraction Library. GDAL for point cloud data

meta.homepage for pdal is: https://pdal.io

Updates performed

• Version update

To inspect upstream changes

• Release on GitHub

• Compare changes on GitHub

Impact

Checks done (click to expand)

---

• built on NixOS
• The tests defined in passthru.tests, if any, passed
• found 2.5.4 with grep in /nix/store/fj6h86v9jb123frf9513x7nhz8bv2s63-pdal-2.5.4
• found 2.5.4 in filename of file in /nix/store/fj6h86v9jb123frf9513x7nhz8bv2s63-pdal-2.5.4

---

Rebuild report (if merged into master) (click to expand)

6 total rebuild path(s)

6 package rebuild(s)

First fifty rebuilds by attrpath
cloudcompare
entwine
grass
pdal
qgis
qgis-ltr

Instructions to test this update (click to expand)

---

Either download from Cachix:

nix-store -r /nix/store/fj6h86v9jb123frf9513x7nhz8bv2s63-pdal-2.5.4 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.

Or, build yourself:

nix-build -A pdal https://github.com/r-ryantm/nixpkgs/archive/06161f191dfe17c01bdb68cbaa688700aac29528.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:

ls -la /nix/store/fj6h86v9jb123frf9513x7nhz8bv2s63-pdal-2.5.4
ls -la /nix/store/fj6h86v9jb123frf9513x7nhz8bv2s63-pdal-2.5.4/bin

---

Pre-merge build results

We have automatically built all packages that will get rebuilt due to
this change.

This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.

Result of nixpkgs-review run on x86_64-linux 1

4 packages failed to build:

• entwine
• grass
• qgis
• qgis-ltr

2 packages built:

• cloudcompare
• pdal

---

Maintainer pings

cc @nh2 for testing.

[nh2]

cloudcompare builds and opens a .las/.laz (which uses PDAL).

Upstream changelog also looks good.

Merging.

[imincik]

@nh2 , this PR breaks GRASS which breaks QGIS which is very important geospatial software. Please consider reverting this change until GRASS is fixed. I reported the same breakage in #210588

[imincik]

GRASS fails on following error:

checking whether to use GDAL... yes
checking for gdal-config... /nix/store/76bsjqgp27k2ymma426snwqa82ip56q5-gdal-3.6.4/bin/gdal-config
checking whether to use libLAS... no
checking whether to use PDAL... yes
checking for pdal-config... /nix/store/fzkglyvnwwyw239jmzwk3sgi2avzpl7a-pdal-2.5.4/bin/pdal-config
checking whether we are using the GNU C++ compiler... yes
checking whether g++ accepts -g... yes
configure: error: *** Unable to locate suitable (>=1.7.1) PDAL library.
error: builder for '/nix/store/j7r3773a6x8ppls28g9mia9n1d1jv86c-grass-8.2.1.drv' failed with exit code 1;
       last 10 log lines:
       > checking for readline in -lreadline... yes
       > checking for add_history in -lhistory... yes
       > checking whether to use GDAL... yes
       > checking for gdal-config... /nix/store/76bsjqgp27k2ymma426snwqa82ip56q5-gdal-3.6.4/bin/gdal-config
       > checking whether to use libLAS... no
       > checking whether to use PDAL... yes
       > checking for pdal-config... /nix/store/fzkglyvnwwyw239jmzwk3sgi2avzpl7a-pdal-2.5.4/bin/pdal-config
       > checking whether we are using the GNU C++ compiler... yes
       > checking whether g++ accepts -g... yes
       > configure: error: *** Unable to locate suitable (>=1.7.1) PDAL library.
       For full logs, run 'nix log /nix/store/j7r3773a6x8ppls28g9mia9n1d1jv86c-grass-8.2.1.drv'.

[imincik]

Actually, I tried to build GRASS in revision before this PR was merged and I've got the same error. So GRASS must be broken for longer time now. What I don't understand is how QGIS was build then.

[nh2]

Actually, I tried to build GRASS in revision before this PR was merged and I've got the same error. So GRASS must be broken for longer time now.

@imincik I cannot confirm that: My check suggests this PR indeed broke it. It passes on commit 06161f191dfe~ where commit 06161f1 is the one merged by this PR.

In any case, on commit 06161f1 (which has this PR merged), I do not get your error shown in your comment above (#215960 (comment)), probably because you already tried with grass 8.2.1 instead of 8.2.0; for me it goes on fine with

checking whether to use PDAL... yes
checking for pdal-config... /nix/store/fzkglyvnwwyw239jmzwk3sgi2avzpl7a-pdal-2.5.4/bin/pdal-config
checking whether we are using the GNU C++ compiler... yes
checking whether g++ accepts -g... yes
checking whether to use NetCDF... yes

then completes configure printing PDAL support: yes and fails later with:

Errors in:
/build/source/raster/r.in.pdal

---

The Unable to locate suitable (>=1.7.1) PDAL library you link looks a bit like OSGeo/grass#2851 (comment).

---

Some other things I don't understand is grass's current code

  nativeBuildInputs = [
    pkg-config bison flex makeWrapper wrapGAppsHook
    gdal geos libmysqlclient netcdf pdal
  ] ++ (with python3Packages; [ python-dateutil numpy wxPython_4_2 ]);

Why is e.g. pdal in this list of build-only dependency? It looks like a normal dependency, thus a runtime dependency that needs to be in buildInputs.

Investigating a bit more:

I updated to grass 8.2.1 as you did (build failure) and then cherry-picked manually OSGeo/grass#2851 which uses pkg-config.
Then pkg-config failed to find pdal.
Indeed putting preConfigure = ''pkg-config --list-all ; exit 1''; shows that it isn't in the list.
I moved it from nativeBuildInputs to buildInputs, then it is found.

Then I switched back to unpatched grass 8.2.1, and kept pdal in buildInputs. Now it complains configure: error: *** could not find pdal-config.

From this I determined that pdal needs to be in both nativeBuildInputs (for pdal-config) and buildInputs (because it's a runtime dependency, and strictDeps = true for this package).

Once the next version of grass is released, we should be able to remove it from nativeBuildInputs because then pdal-config is no longer used.

I will make a according PR.

[nh2]

PR at #235043

[imincik]

@nh2 , huge thanks for debugging the problem and sorry for little confusing comments. I think I agree with all your findings. You really made my day much nicer. I am going to review and test GRASS PR now. Thank you !