Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

openssl: 3.0.8 -> 3.1.0 #221206

Closed
wants to merge 2 commits into from
Closed

Conversation

ajs124
Copy link
Member

@ajs124 ajs124 commented Mar 14, 2023

Description of changes

https://www.openssl.org/news/openssl-3.1-notes.html

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@vcunat
Copy link
Member

vcunat commented Mar 14, 2023

I can't see anything risky in changelog: https://www.openssl.org/news/cl31.txt
so perhaps we could just stage it without extensive testing.

@ajs124
Copy link
Member Author

ajs124 commented Mar 14, 2023

According to https://www.openssl.org/policies/releasestrat.html:

Version 3.1 will be supported until 2025-03-14
Version 3.0 will be supported until 2026-09-07 (LTS).

So maybe we actually want to stick with 3.0.x?

@mweinelt
Copy link
Member

mweinelt commented Mar 14, 2023

I don't think we should stick with it.

Maybe we should keep it around, but I'm not sure yet who its consumers might be.

Let's wait until someone complains? A version we track is something we have to clean up at some point, so the fewer things we track the better.

@mweinelt
Copy link
Member

@ofborg eval

@ajs124
Copy link
Member Author

ajs124 commented Mar 15, 2023

Well, ibm-sw-tpm2 fails to build, which is an issue since systemd depend on it through tpm2-tss.

My argument for sticking with 3.0.x boils down to "it's an LTS release". Apparently that gives us 1.5 more years to switch to the next minor (or mayor) release.

@yu-re-ka yu-re-ka mentioned this pull request Apr 25, 2023
12 tasks
@tomberek
Copy link
Contributor

tomberek commented May 2, 2023

don't think we should stick with it.

Agreed, there shouldn't be a need for both 3.0 and 3.1.

Well, ibm-sw-tpm2 fails to build, which is an issue since systemd depend on it through tpm2-tss.

The failure seems to be with ibm-sw-tpm2 not being updated to understand the newer openssl version. Please see (kgoldman/ibmswtpm2@15501bf) and any relevant Nixpkgs bump.

@ajs124
Copy link
Member Author

ajs124 commented May 2, 2023

Personally, I intend to keep OpenSSL on LTS releases, because even updating it to those is more than enough effort (see e.g. #150093 and #210452).

If anyone sees real value in being on 3.1 (or any other non-LTS release) instead of 3.0 (or a future LTS release) and is willing to put in the work for this to actually work in nixpkgs… well, they can go ahead and do that, but tbh I'll probably stop trying to work on OpenSSL in nixpkgs, because those efforts will probably just end up like what lead to #215109.

@zendo zendo mentioned this pull request May 2, 2023
12 tasks
@ajs124 ajs124 closed this Jun 1, 2023
@vcunat vcunat mentioned this pull request Aug 4, 2023
12 tasks
@thillux thillux mentioned this pull request Sep 7, 2024
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants