Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python310Packages.twisted: Disable tests using legacy algos from crypt #221636

Merged
merged 1 commit into from
Mar 17, 2023

Conversation

mweinelt
Copy link
Member

@mweinelt mweinelt commented Mar 17, 2023

The tests were unconiditonally using crypt methods that we don't support anymore. The patch has also been submitted upstream at twisted/twisted#11827

Fixes: https://hydra.nixos.org/log/nwa5asbsr5vvvwimvh7qyjfggf95n20w-python3.10-twisted-22.10.0.drv

cc #221461

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

The tests were unconiditonally using crypt methods that we don't
support anymore. The patch has also been submitted upstream.
@mweinelt mweinelt merged commit 1cdc67f into NixOS:staging-next Mar 17, 2023
@mweinelt mweinelt deleted the twisted-crypt branch March 17, 2023 12:27
@vcunat
Copy link
Member

vcunat commented Mar 20, 2023

It's weird that another one of the tests regressed, but only with python 3.11 and on x86_64-linux: https://hydra.nixos.org/build/213171652#tabs-buildsteps (same single test in all three attempts on different machines)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants