dovecot: avoid testing DES-encrypted passwords #222022
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Perhaps you'd like to also like to add |
Sounds like a good idea. |
github-actions
bot
added
6.topic: nixos
fpletz
approved these changes
Mar 20, 2023
There was a problem hiding this comment.
When using a custom passwd/shadow file for dovecot, the command doveadm pw generates a bcrypt based hash by default - even before the libxcrypt changes. I don't think anyone still uses DES and if they do, they should upgrade anyways (e.g. because only the first 8 characters of the plain password are actually hashed).
|
IIRC the default changed at the start of |
ajs124
approved these changes
Mar 20, 2023
| @@ -41,6 +41,9 @@ stdenv.mkDerivation rec { | |||
| sed -i -s -E 's!\bcat\b!${coreutils}/bin/cat!g' src/lib-smtp/test-bin/*.sh | |||
|
|
|||
| patchShebangs src/config/settings-get.pl | |||
|
|
|||
| # DES-encrypted passwords are not supported by NixPkgs anymore | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Those tests wouldn't work since #220557
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)