haskell.packages.*.vector: clean up and unify overrides, run tests #222190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- The dontCheck overrides are not necessary completely. It seems that there is some kind of issue with the doctest suite, but we can run the other ones. - We need a jailbreak everywhere due to doctest (ironically), so we can move that into the common configuration. - The i686 issue has been closed upstream. Tested locally to confirm that it is indeed not a problem anymore.
|
@ofborg build haskell.packages.ghc884.vector haskell.packages.ghc8107.vector haskell.packages.ghc902.vector haskell.packages.ghc927.vector haskell.packages.ghc944.vector haskell.packages.ghc961.vector |
|
Looks like staging was merged into |
sternenseemann
added a commit
that referenced
this pull request
Mar 27, 2023
doctest depends on GHC which triggers inconsistent dependencies similarly to hspec* < 2.10, so we need to avoid this. This problem newly cropped up since we enabled tests for vector in #222190.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The dontCheck overrides are not necessary completely. It seems that there is some kind of issue with the doctest suite, but we can run the other ones.
We need a jailbreak everywhere due to doctest (ironically), so we can move that into the common configuration.
The i686 issue has been closed upstream. Tested locally to confirm that it is indeed not a problem anymore.
We may want to wait with merging until the next iteration as it is probably a big rebuild.
Description of changes
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)