Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libxcrypt: add -legacy variant #223034

Merged
merged 2 commits into from
Mar 25, 2023
Merged

libxcrypt: add -legacy variant #223034

merged 2 commits into from
Mar 25, 2023

Conversation

vcunat
Copy link
Member

@vcunat vcunat commented Mar 25, 2023

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@vcunat vcunat requested review from mweinelt and thiagokokada March 25, 2023 09:51
@vcunat
Copy link
Member Author

vcunat commented Mar 25, 2023

/cc the target: PR #221461

@vcunat vcunat mentioned this pull request Mar 25, 2023
Merged
12 tasks
@ofborg ofborg bot added the 8.has: package (new) This PR adds a new package label Mar 25, 2023
@mweinelt mweinelt merged commit 40aed56 into NixOS:staging-next Mar 25, 2023
@vcunat vcunat deleted the p/libxcrypt-legacy branch March 25, 2023 12:06
@KiruyaMomochi
Copy link
Contributor

Result of nixpkgs-review pr 223034 run on x86_64-linux 1

39 packages failed to build:
  • babashka
  • bbin
  • clj-kondo
  • clojure-lsp
  • dapl-native
  • dbqn-native
  • graalvm-ce (graalvm11-ce ,graalvmCEPackages.graalvm11-ce)
  • graalvm17-ce (graalvmCEPackages.graalvm17-ce)
  • graalvm19-ce (graalvmCEPackages.graalvm19-ce)
  • graalvmCEPackages.graalvm11-ce-full
  • graalvmCEPackages.graalvm17-ce-full
  • graalvmCEPackages.graalvm19-ce-full
  • graalvmCEPackages.js-installable-svm-java11
  • graalvmCEPackages.js-installable-svm-java17
  • graalvmCEPackages.js-installable-svm-java19
  • graalvmCEPackages.llvm-installable-svm-java11
  • graalvmCEPackages.llvm-installable-svm-java17
  • graalvmCEPackages.llvm-installable-svm-java19
  • graalvmCEPackages.native-image-installable-svm-java11
  • graalvmCEPackages.native-image-installable-svm-java17
  • graalvmCEPackages.native-image-installable-svm-java19
  • graalvmCEPackages.nodejs-installable-svm-java11
  • graalvmCEPackages.nodejs-installable-svm-java17
  • graalvmCEPackages.nodejs-installable-svm-java19
  • graalvmCEPackages.python-installable-svm-java11
  • graalvmCEPackages.python-installable-svm-java17
  • graalvmCEPackages.python-installable-svm-java19
  • graalvmCEPackages.ruby-installable-svm-java11
  • graalvmCEPackages.ruby-installable-svm-java17
  • graalvmCEPackages.ruby-installable-svm-java19
  • graalvmCEPackages.wasm-installable-svm-java11
  • graalvmCEPackages.wasm-installable-svm-java17
  • graalvmCEPackages.wasm-installable-svm-java19
  • jet
  • libxcrypt-legacy
  • libxcrypt-legacy.man
  • neil
  • vscode-extensions.betterthantomorrow.calva
  • zprint

@cpu cpu mentioned this pull request Nov 30, 2024
Open
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mweinelt mweinelt mweinelt approved these changes

@thiagokokada thiagokokada Awaiting requested review from thiagokokada

@bennyandresen bennyandresen Awaiting requested review from bennyandresen

@ericdallo ericdallo Awaiting requested review from ericdallo

@hlolli hlolli Awaiting requested review from hlolli

@glittershark glittershark Awaiting requested review from glittershark

@babariviere babariviere Awaiting requested review from babariviere

Assignees
No one assigned
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vcunat @KiruyaMomochi @mweinelt