Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

llvmPackages_git.compiler-rt: disable iPhone simulator #223256

Merged
merged 1 commit into from
Apr 15, 2023
Merged

llvmPackages_git.compiler-rt: disable iPhone simulator #223256

merged 1 commit into from
Apr 15, 2023

Conversation

RaitoBezarius
Copy link
Member

Description of changes

Backport of LLVM15 change.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@RaitoBezarius RaitoBezarius force-pushed the llvmPackages_git.compiler-rt branch 2 times, most recently from 9442463 to e3e564e Compare March 26, 2023 15:32
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Mar 26, 2023
@rrbutani rrbutani mentioned this pull request Mar 26, 2023
Closed
48 tasks
@RaitoBezarius RaitoBezarius changed the base branch from staging to master April 4, 2023 11:40
@rrbutani @RaitoBezarius
llvmPackages_git.compiler-rt: fixes for Darwin
6707fa4 
Partial port of 00839fe
("llvmPackages_15.compiler-rt: fixes for Darwin")

see: #194634 (comment)
@RaitoBezarius RaitoBezarius marked this pull request as ready for review April 5, 2023 15:30
@RaitoBezarius
Copy link
Member Author

@ofborg build llvmPackages_git.compiler-rt.aarch64-darwin llvmPackages_git.compiler-rt.x86_64-darwin

@RaitoBezarius
Copy link
Member Author

Let's do something simpler:

@ofborg build llvmPackages_git.compiler-rt

@RaitoBezarius RaitoBezarius merged commit dde4134 into master Apr 15, 2023
@RaitoBezarius RaitoBezarius deleted the llvmPackages_git.compiler-rt branch May 8, 2023 20:00
@rrbutani rrbutani added the 6.topic: llvm/clang Issues related to llvmPackages, clangStdenv and related label May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rrbutani rrbutani rrbutani approved these changes

@alyssais alyssais Awaiting requested review from alyssais

@matthewbauer matthewbauer Awaiting requested review from matthewbauer

Assignees
No one assigned
Labels
6.topic: llvm/clang Issues related to llvmPackages, clangStdenv and related 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RaitoBezarius @rrbutani