Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tcl, tk: 8.6.11 -> 8.6.13 #223377

Merged
merged 1 commit into from
Apr 26, 2023
Merged

tcl, tk: 8.6.11 -> 8.6.13 #223377

merged 1 commit into from
Apr 26, 2023

Conversation

wegank
Copy link
Member

@wegank wegank commented Mar 27, 2023

Description of changes

Supersedes #163181.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added the ofborg-internal-error Ofborg encountered an error label Mar 27, 2023
@wegank
Copy link
Member Author

wegank commented Mar 27, 2023

@ofborg eval

@wegank wegank marked this pull request as ready for review March 31, 2023 07:01
@wegank
Copy link
Member Author

wegank commented Mar 31, 2023

@ofborg build tcl tcl.passthru.tests tk tk.passthru.tests

@cole-h cole-h removed the ofborg-internal-error Ofborg encountered an error label Apr 16, 2023
@vcunat vcunat merged commit 28a65aa into NixOS:staging Apr 26, 2023
@vcunat
Copy link
Member

vcunat commented Apr 26, 2023

Uh, stdenv rebuild? 🤞🏽

@wegank wegank deleted the tcl-tk-bump branch April 26, 2023 14:10
@wegank
Copy link
Member Author

wegank commented May 16, 2023

I think something went wrong with this update, see issues #232089 and #232148.

@wegank
Copy link
Member Author

wegank commented May 16, 2023

Wait, I'm confused, there is an easy fix: --set TK_LIBRARY ${tk}/lib/${tk.libPrefix}...

@jchv
Copy link
Contributor

jchv commented May 16, 2023

Just for what it's worth, I don't think that #232089 and #232148 are related. The dtdocbook/instant program in CDE seems to build and link properly, and it only really seems to fail due to some specific locale issue. It's perfectly able to link to Tcl 8.6 and the only reason I wind up overriding TCLLIB in #232148 is so I can get CDE to link to 8.5 instead to work around the issue. It's necessary because CDE hardcodes -ltcl8.6 (but does still support 8.5 in version 2.3.2 as far as I can tell, having looked through the mailing list.)

There may be some overarching problem with this update that lead to #232148, but my personal suspicion is that it's actually a dependency update in Tcl that broke some old deprecated locales (maybe ones that are not ISO/IEC 2022 compliant, or perhaps otherwise just too archaic to keep supporting.) But, that's just my hunch, and I haven't had time to properly root-cause it yet.

Just wanted to make this note here to hopefully prevent any unnecessary confusion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants