Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kube-linter: 0.6.0 -> 0.6.1 #224235

Merged
merged 1 commit into from
Apr 1, 2023
Merged

Conversation

Intuinewin
Copy link
Member

Description of changes

https://github.com/stackrox/kube-linter/releases/tag/v0.6.1

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@Intuinewin Intuinewin changed the title kube-linter: 0.6.1 -> 0.6.1 kube-linter: 0.6.0 -> 0.6.1 Apr 1, 2023
@fabaff
Copy link
Member

fabaff commented Apr 1, 2023

Result of nixpkgs-review pr 224235 run on x86_64-linux 1

1 package built:
  • kube-linter

@stehessel
Copy link
Contributor

changelog   = "https://github.com/stackrox/kube-linter/releases/tag/${version}";

I guess this needs to be v${version} now? Curious that the tag naming scheme was changed.

@Intuinewin
Copy link
Member Author

changelog   = "https://github.com/stackrox/kube-linter/releases/tag/${version}";

I guess this needs to be v${version} now? Curious that the tag naming scheme was changed.

Indeed, I'll change that. For the reason for this change, you can check this issue: stackrox/kube-linter#494

@ofborg ofborg bot requested a review from stehessel April 1, 2023 19:26
@SuperSandro2000 SuperSandro2000 merged commit aac231d into NixOS:master Apr 1, 2023
@Intuinewin Intuinewin deleted the kube-linter-0.6.1 branch April 2, 2023 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants