Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mozart: use llvmPackages_8 instead of llvmPackages_5 #224639

Merged
merged 2 commits into from
Apr 4, 2023
Merged

Conversation

RaitoBezarius
Copy link
Member

Description of changes

Following issue #44372 logic, we want to get rid of older LLVMs.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Following issue #44372 logic, we want to get rid of older LLVMs.
@ofborg ofborg bot requested review from layus and h7x4 April 4, 2023 12:04
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Apr 4, 2023
@layus
Copy link
Member

layus commented Apr 4, 2023

@RaitoBezarius Thanks so much for having a look at this one. I pushed a commit that simplifies everything ;-). That old llvm has to be llvm4, but the sources we fetch are preprocessed, and do not need that build step anymore.

  • Built and tested on x86_64-linux

@RaitoBezarius
Copy link
Member Author

Awesome!

@ofborg ofborg bot requested a review from layus April 4, 2023 13:51
@layus layus merged commit c5e6843 into master Apr 4, 2023
@alyssais alyssais deleted the mozart/bump-llvm8 branch April 5, 2023 01:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants