zstd: 1.5.4 → 1.5.5

[andersk]

Description of changes

This release fixes a rare but serious corruption bug.

• Release notes
• Commit log

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 23.05 Release Notes (or backporting 22.11 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

[viraptor]

I think you accidentally converted -> into a a unicode symbol. This should be plain ascii to play nicely with tooling.

[zowoq]

This should be plain ascii to play nicely with tooling.

Which tooling?

maintainers/scripts/update.nix uses unicode:

nixpkgs/maintainers/scripts/update.py

Line 103 in 7884a01

commit_message = '{attrPath}: {oldVersion} → {newVersion}'.format(**change)

[viraptor]

Mine :)
That does not match the contributing doc, so it was surprising: https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md#submitting-changes I'll post a PR to asciify and see what's the consensus...

[andersk]

I use a Unicode → intentionally, and I’m not the only one.

❯ git log --oneline --grep=→ | wc -l
5730

If it breaks your tooling, consider fixing your tooling?

[viraptor]

Offtopic here, relevant PR at #224746

[andersk]

(Does this need to go through staging due to the rebuild count?)

[Artturin]

(Does this need to go through staging due to the rebuild count?)

Yes

[nixos-discourse]

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/2060