Various pypy3Packages fixes #225137
Merged
Various pypy3Packages fixes #225137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
78
to
81
| ] ++ lib.optionals (isPyPy) [ | ||
| "test_bash" | ||
| "test_can_build_c_extensions" | ||
| "test_discover_ok" |
There was a problem hiding this comment.
Those just don't work on pypy?
There was a problem hiding this comment.
virtualenv> FAILED tests/unit/activation/test_bash.py::test_bash[with_prompt] - AssertionError: /nix/store/hd9sv84a4b5yk3kvnpgy51qqd4zh8bf5-pypy3.9-7.3.11/...
virtualenv> FAILED tests/unit/activation/test_bash.py::test_bash[no_prompt] - AssertionError: /nix/store/hd9sv84a4b5yk3kvnpgy51qqd4zh8bf5-pypy3.9-7.3.11/...
virtualenv> FAILED tests/unit/create/via_global_ref/test_build_c_ext.py::test_can_build_c_extensions[venv] - PermissionError: [Errno 13] Permission denied: PosixPath('/build/pytest-of-...
virtualenv> FAILED tests/unit/discovery/py_info/test_py_info_exe_based_of.py::test_discover_ok[PyPy-3.9.16-64-bin-] - RuntimeError: failed to detect pypy3.9.16-64|pypy3.9.16|pypy3.9-64|pypy3.9|...
virtualenv> FAILED tests/unit/discovery/py_info/test_py_info_exe_based_of.py::test_discover_ok[PyPy-3.9.16--bin-] - RuntimeError: failed to detect pypy3.9.16-64|pypy3.9.16|pypy3.9-64|pypy3.9|...
virtualenv> FAILED tests/unit/discovery/py_info/test_py_info_exe_based_of.py::test_discover_ok[PyPy-3.9-64-bin-] - RuntimeError: failed to detect pypy3.9.16-64|pypy3.9.16|pypy3.9-64|pypy3.9|...
virtualenv> FAILED tests/unit/discovery/py_info/test_py_info_exe_based_of.py::test_discover_ok[PyPy-3.9--bin-] - RuntimeError: failed to detect pypy3.9.16-64|pypy3.9.16|pypy3.9-64|pypy3.9|...
virtualenv> FAILED tests/unit/discovery/py_info/test_py_info_exe_based_of.py::test_discover_ok[PyPy-3-64-bin-] - RuntimeError: failed to detect pypy3.9.16-64|pypy3.9.16|pypy3.9-64|pypy3.9|...
virtualenv> FAILED tests/unit/discovery/py_info/test_py_info_exe_based_of.py::test_discover_ok[PyPy-3--bin-] - RuntimeError: failed to detect pypy3.9.16-64|pypy3.9.16|pypy3.9-64|pypy3.9|...
virtualenv> FAILED tests/unit/discovery/py_info/test_py_info_exe_based_of.py::test_discover_ok[python-3.9.16-64-bin-] - RuntimeError: failed to detect pypy3.9.16-64|pypy3.9.16|pypy3.9-64|pypy3.9|...
virtualenv> FAILED tests/unit/discovery/py_info/test_py_info_exe_based_of.py::test_discover_ok[python-3.9.16--bin-] - RuntimeError: failed to detect pypy3.9.16-64|pypy3.9.16|pypy3.9-64|pypy3.9|...
virtualenv> FAILED tests/unit/discovery/py_info/test_py_info_exe_based_of.py::test_discover_ok[python-3.9-64-bin-] - RuntimeError: failed to detect pypy3.9.16-64|pypy3.9.16|pypy3.9-64|pypy3.9|...
virtualenv> FAILED tests/unit/discovery/py_info/test_py_info_exe_based_of.py::test_discover_ok[python-3.9--bin-] - RuntimeError: failed to detect pypy3.9.16-64|pypy3.9.16|pypy3.9-64|pypy3.9|...
virtualenv> FAILED tests/unit/discovery/py_info/test_py_info_exe_based_of.py::test_discover_ok[python-3-64-bin-] - RuntimeError: failed to detect pypy3.9.16-64|pypy3.9.16|pypy3.9-64|pypy3.9|...
virtualenv> FAILED tests/unit/discovery/py_info/test_py_info_exe_based_of.py::test_discover_ok[python-3--bin-] - RuntimeError: failed to detect pypy3.9.16-64|pypy3.9.16|pypy3.9-64|pypy3.9|...
The 2to3 conversion utiliy is not available for pypy, so the package is essentially using python2 syntax which breaks it.
Nose tests is not getting updated for python3 and shouldn't be used anymore. In fact it can't be used on pypy, since it does not come with a 2to3 utility.
Cannot be tested, because it is using nose for tests, which is broken for pypy.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows building up to
pypy3Packages.cryptography.Description of changes
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)