-
-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perl: fix modules for compatibility with miniperl #225640
Conversation
5269229
to
89da019
Compare
Using builtins seems like a nice solution, I'll have a look! |
I can help test this on aarch64. What commands should I run? |
I rebased over master on my nixpkgs fork: G3zz@f5c7e6e |
The compilation of ModuleBuild give confidence for the patch. Thanks for your offer, but I do not know what else could be tested. |
Hi there! I think this looks like an interesting fix to issues with cross build. Planning on looking at this when perl-5.38.0 drops next week. The patches might need some work for 5.38.0 though. |
I tried it on recent nixos-23.05 branch (with minimal required change -- one file renamed), it works and even allow me to build |
Added compatibility for - CPAN::Meta - JSON::PP - Data::Dumper
89da019
to
2d6f287
Compare
Thanks for testing. I updated this PR to the latest version of branch statging. |
I've included these commits, and updated them for perl-5.38.0 in: |
Great, thanks. I will close this PR. |
This has now been merged into staging, if anyone would like to test cross-builds |
Description of changes
When perl modules are cross-compiled, miniperl is used which do not allow dynamic loading.
This PR adds compatibitly for miniperl to following modules:
Additionally, this PR fixes #66741, the cross compilation for Perl module ModuleBuild. Following command will succeed:
Things done
sandbox = true
set innix.conf
? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)