-
-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gst_all_1: 1.20.3 -> 1.22.2 #226473
Merged
Merged
gst_all_1: 1.20.3 -> 1.22.2 #226473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Per the release schedule, this can land until 2023/05/01, but we should probably include it right in the next staging cycle, so we have enough time to account for potential regressions. |
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
I was hoping this could make it into 23.05 so that we aren't stuck on stable with an old GStreamer release that won't receive any more fixes. I couldn't find a document describing GStreamer's support model, but they seem to generally make one final bug fix release after a new stable is available and this already occured in late February
If GStreamer 1.22 (which supposedly 1.x releases should be backwards-compatible according to the project, but I did not empirically test this) is not acceptable for 23.05, then I will submit another PR for 1.20.3 -> 1.20.6 and this PR can be marked draft and wait until after branch-off
@RaitoBezarius and @mweinelt, is this acceptable for 23.05?
Release notes: https://gstreamer.freedesktop.org/releases/1.22/
I additionally packaged hotdoc, but currently the generated .json files aren't actually copied to a devdoc output (and to turn those json files into usable documentation, we'd need to package gst-doc and provide those json files to it anyway). Adding it does mean that some helper libexecs for generating documentation are now included in the output, though, which can be helpful
Also if these packages are in need of more maintainers, I'm happy to add myself and ensure they stay relatively up-to-date and functional. Many plugins that do work now are still disabled (which I plan to re-evaluate soon) and there have been several bug fix bumps since the version we have packaged (which was released mid-last-year). Also I'm going to be maintaining gst_all_1.gst-plugins-rs already from #225143
Things done
sandbox = true
set innix.conf
? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)