Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

avahi: split headers to "dev" output #226507

Merged
merged 1 commit into from
Apr 22, 2023
Merged

Conversation

trofi
Copy link
Contributor

@trofi trofi commented Apr 16, 2023

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@trofi
Copy link
Contributor Author

trofi commented Apr 16, 2023

avahi-compat fails to install headers in a wrong directory:

avahi-compat> ln: failed to create symbolic link '/nix/store/p71q03ibn5gccjhw4iqilis6ifvlfznj-avahi-compat-0.8/include/dns_sd.h': No such file or directory

Switching to draft.

@trofi trofi marked this pull request as ready for review April 16, 2023 20:57
@trofi
Copy link
Contributor Author

trofi commented Apr 16, 2023

Ended up being a symlink to $out in nix expression. Fixed. Ready for review.

@vcunat vcunat added the 6.topic: closure size The final size of a derivation, including its dependencies label Apr 17, 2023
@Artturin
Copy link
Member

nix build ".#liblxi" ".#gvfs" ".#geoclue2" ".#hplip"

@Artturin Artturin merged commit 92c3f43 into NixOS:staging Apr 22, 2023
@trofi trofi deleted the avahi-dev-output branch April 22, 2023 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants