Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

liblc3: split headers to "dev" output #226596

Merged
merged 1 commit into from
Apr 17, 2023
Merged

liblc3: split headers to "dev" output #226596

merged 1 commit into from
Apr 17, 2023

Conversation

trofi
Copy link
Contributor

@trofi trofi commented Apr 17, 2023 •
edited
Loading

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from jansol April 17, 2023 07:23
@jansol
Copy link
Contributor

jansol commented Apr 17, 2023

@ofborg build pipewire

jansol
jansol approved these changes Apr 17, 2023
View reviewed changes
Copy link
Contributor

@jansol jansol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't test this week but as long as this does not regress pipewire I have no objections.

@jansol jansol requested a review from K900 April 17, 2023 08:57
@K900 K900 merged commit 3bdb45c into NixOS:staging Apr 17, 2023
@trofi trofi deleted the liblc3-dev-output branch April 17, 2023 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jansol jansol jansol approved these changes

@K900 K900 Awaiting requested review from K900

Assignees
No one assigned
Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 501+ 10.rebuild-linux: 2501-5000
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@trofi @jansol @K900