Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python310Packages.watchdog: 2.3.0 -> 2.3.1 #226730

Merged
merged 1 commit into from
Apr 26, 2023

Conversation

mweinelt
Copy link
Member

https://github.com/gorakhargosh/watchdog/blob/v2.3.1/changelog.rst

less risky than #225406

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@dylanmtaylor
Copy link
Member

Looking at https://github.com/gorakhargosh/watchdog/blob/master/changelog.rst#300 I don't see too much to be concerned about. Largely just code quality changes and dropping Python 3.6. I would suggest #225406 be merged instead.

@vcunat vcunat merged commit b58f4b8 into NixOS:staging Apr 26, 2023
@vcunat
Copy link
Member

vcunat commented Apr 26, 2023

I don't know. Say, the less risky one now for 23.05.

@mweinelt mweinelt deleted the python-watchdog-2.3.1 branch April 26, 2023 14:00
@mweinelt
Copy link
Member Author

Looking at gorakhargosh/watchdog@master/changelog.rst#300 I don't see too much to be concerned about. Largely just code quality changes and dropping Python 3.6. I would suggest #225406 be merged instead.

Yeah, but projects will have pins that say <3, which will ripple through the package set, and I'm not in a position to resolve these right now.

@vcunat
Copy link
Member

vcunat commented Apr 30, 2023

Oh, the conditional patch doesn't apply:
https://hydra.nixos.org/build/217596281

@vcunat
Copy link
Member

vcunat commented Apr 30, 2023

Dropping the patch doesn't help, as the original issue seems to still apply, as described in PR #171388

@mweinelt
Copy link
Member Author

mweinelt commented Apr 30, 2023

Planning to go with #225406 instead. It has the updated patch. Rebase and testing in progress.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants