pcb2gcode: fix build on darwin #226929
Merged
pcb2gcode: fix build on darwin #226929
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofborg
bot
added
6.topic: darwin
wegank
reviewed
Apr 19, 2023
wegank
reviewed
Apr 19, 2023
Comment on lines
27
to
29
| CFLAGS = [ | ||
| "-Wno-format-security" | ||
| ]; |
There was a problem hiding this comment.
Does the following work for you?
Suggested change
| CFLAGS = [ | |
| "-Wno-format-security" | |
| ]; | |
| env.NIX_CFLAGS_COMPILE = "-Wno-format-security"; |
There was a problem hiding this comment.
Yep, works for me. Out of curiosity, I did some digging and I see discussion on about phasing out NIX_CFLAGS_COMPILE. Is there a source on where I can learn about the nuance between them?
There was a problem hiding this comment.
I consider env.NIX_CFLAGS_COMPILE to be more uniform. Other environmental variables could of course work here or there.
This version bumps gerbv as well.
cransom
force-pushed
the
pcb2gcode-darwin
branch
from
0e90653 to
3ed1e3b
Compare
|
@wegank Updated. Thanks for looking! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This version bumps gerbv as well.
Description of changes
Version bumps and changes the source for a dependency, gerbv, to sourceforge which seems to be the official download spot.
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)