Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libdecor: 0.1.0 -> 0.1.1, remove unused dependency #227464

Merged
merged 2 commits into from
Apr 22, 2023

Conversation

Kiskae
Copy link
Contributor

@Kiskae Kiskae commented Apr 21, 2023

Description of changes

Prompted by #227457 when investigating why libdecor depends on the nvidia egl platform.

  • Updated project home per notice on the old repository
  • Update to 0.1.1
  • Turns out egl should be provided by libGL, but since it is only required by the unused demo application I just disabled it and removed the dependency.

@Artturin I noticed that there is an libdecor-gtk.so plugin that isn't currently being built. I didn't add a gtk3 dependency since I'm not sure what the purpose of those plugins is but you might want to have a look.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@Kiskae
Copy link
Contributor Author

Kiskae commented Apr 21, 2023

It looks like the libdecor-gtk plugin was added after the 0.1.1 release, my bad

@Artturin Artturin merged commit 99e5249 into NixOS:staging Apr 22, 2023
@Kiskae Kiskae deleted the decor-fix-egl branch April 22, 2023 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants