WIP: add depsBuildHost depsHostTarget #227502
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Artturin
force-pushed
the
adddepsBuildHostdepsHostTarget
branch
from
734c58c to
5d9959c
Compare
ghost
self-requested a review
added 2 commits
April 23, 2023 16:24
|
CI should be green now. |
ghost
approved these changes
Apr 23, 2023
There was a problem hiding this comment.
Obviously this should wait until after 23.05.
I also think we should merge a treewide sed -i search-and-replace simultaneously with this PR. We're going to get a lot of breakage either way, but if the treewide is done at the same time we'll get easier to diagnose breakage.
| @@ -140,7 +142,8 @@ let | |||
|
|
|||
| inherit buildPlatform hostPlatform targetPlatform; | |||
|
|
|||
| inherit extraNativeBuildInputs extraBuildInputs | |||
| inherit extraDepsBuildHost extraDepsHostTarget | |||
| extraNativeBuildInputs extraBuildInputs | |||
There was a problem hiding this comment.
Suggested change
| extraNativeBuildInputs extraBuildInputs |
wegank
added
the
12.approvals: 1
wegank
added
2.status: stale
stale
bot
removed
the
2.status: stale
wegank
added
the
2.status: stale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#28327
#227327
Description of changes
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)