Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stdenv: avoid -p flag for strip on aarch64-darwin #227919

Merged
merged 1 commit into from
Apr 24, 2023

Conversation

wegank
Copy link
Member

@wegank wegank commented Apr 24, 2023

Description of changes

#226795

$ nix-build -A ghc
/nix/store/22qpwifg291lr8570vwi75kkfhq75d7g-ghc-9.2.7
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Apr 24, 2023
@github-actions github-actions bot added the 6.topic: stdenv Standard environment label Apr 24, 2023
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Apr 24, 2023
@wegank wegank marked this pull request as draft April 24, 2023 08:38
@wegank wegank closed this Apr 24, 2023
@wegank wegank deleted the darwin-strip-p branch April 24, 2023 08:39
@wegank wegank restored the darwin-strip-p branch April 24, 2023 15:40
@wegank wegank reopened this Apr 24, 2023
@wegank wegank marked this pull request as ready for review April 24, 2023 15:41
@vcunat vcunat merged commit e167eac into NixOS:staging-next Apr 24, 2023
@vcunat
Copy link
Member

vcunat commented Apr 24, 2023

OK. Commits are cheap, in the unlikely case that a different opinion appears. Now's a good time to start rebuilds.

@wegank wegank deleted the darwin-strip-p branch April 24, 2023 18:51
@vcunat vcunat mentioned this pull request Apr 25, 2023
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: darwin Running or building packages on Darwin 6.topic: stdenv Standard environment 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants