Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qt6.qtmultimedia: fix build on aarch64-darwin #228151

Merged
merged 1 commit into from
Apr 25, 2023

Conversation

wegank
Copy link
Member

@wegank wegank commented Apr 25, 2023

Description of changes

https://hydra.nixos.org/job/nixpkgs/staging-next/qt6.qtmultimedia.aarch64-darwin

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@wegank
Copy link
Member Author

wegank commented Apr 25, 2023

@ofborg build qt6.qtmultimedia qt6.qtmultimedia.passthru.tests

@NickCao
Copy link
Member

NickCao commented Apr 25, 2023

According to the qt 6.5 release note: https://www.qt.io/blog/qt-6.5-lts-released#qt-multimedia, the default backend for qtmultimedia is now ffmpeg instead of gstreamer. Shall we migrate to ffmpeg too? Supposedly it would also fix the build on darwin, as this pr originally intends.

@ofborg ofborg bot added 6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 11-100 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Apr 25, 2023
@wegank
Copy link
Member Author

wegank commented Apr 25, 2023

Shall we migrate to ffmpeg too?

Honestly, I have no idea if this will break any packages. Will test when Hydra finishes building qt6.qtmultimedia on aarch64-linux.

@wegank wegank force-pushed the qt6-qtmultimedia-darwin branch from d6d7de8 to 112480f Compare April 25, 2023 15:28
@wegank wegank merged commit e6990a4 into NixOS:staging-next Apr 25, 2023
@wegank wegank deleted the qt6-qtmultimedia-darwin branch April 25, 2023 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 11-100 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants