Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

netbox: 3.4.7 -> 3.5.0 #228405

Merged
merged 3 commits into from
Apr 29, 2023
Merged

netbox: 3.4.7 -> 3.5.0 #228405

merged 3 commits into from
Apr 29, 2023

Conversation

minijackson
Copy link
Member

@minijackson minijackson commented Apr 26, 2023 •
edited
Loading

Description of changes

Changes:

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@dasJ dasJ requested a review from mweinelt April 26, 2023 22:27
@minijackson minijackson changed the title netbox: 3.4.7 -> 3.4.9 netbox: 3.4.7 -> 3.4.10 Apr 27, 2023
@minijackson
Copy link
Member Author

Welp, a new breaking version just released: https://github.com/netbox-community/netbox/releases/tag/v3.5.0 (so fast!)

According to the release schedule, this means NetBox 3.5.0 will not be in NixOS 23.05, is that correct @RaitoBezarius?

Is there a branch I can target for the "next" NixOS unstable, or should I wait for branch-off?

@yu-re-ka
Copy link
Contributor

yu-re-ka commented Apr 27, 2023 •
edited
Loading

Netbox 3.5.0 can make it into NixOS 23.05 if it is merged into master before 2023-05-22.

@minijackson
Copy link
Member Author

Oh, I inverted the meaning of the sentence. I'll propose the change in this PR then.

@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: changelog 8.has: documentation labels Apr 27, 2023
@minijackson minijackson changed the title netbox: 3.4.7 -> 3.4.10 netbox: 3.4.7 -> 3.5.0 Apr 27, 2023
yu-re-ka
yu-re-ka approved these changes Apr 27, 2023
View reviewed changes
Copy link
Contributor

@yu-re-ka yu-re-ka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran nixos test on aarch64-linux

@ofborg ofborg bot requested a review from n0emis April 27, 2023 20:38
@yu-re-ka yu-re-ka merged commit 0c97d30 into NixOS:master Apr 29, 2023
@minijackson minijackson deleted the netbox-3.4.9 branch May 2, 2023 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yu-re-ka yu-re-ka yu-re-ka approved these changes

@mweinelt mweinelt Awaiting requested review from mweinelt

@RaitoBezarius RaitoBezarius Awaiting requested review from RaitoBezarius

@n0emis n0emis Awaiting requested review from n0emis

Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: changelog 8.has: documentation 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
Nix documentation
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@minijackson @yu-re-ka