stdenv: factor out meta attr augmentation for reusability
#228759
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 tasks
|
I think the eval failure is due to less laziness |
Artturin
force-pushed
the
splitfactoroutmeta
branch
2 times, most recently
from
58ddcbb
to
e92eb75
Compare
|
Thank you for splitting out this change! |
Artturin
force-pushed
the
splitfactoroutmeta
branch
from
e92eb75
to
178448e
Compare
Artturin
requested review from
Ericson2314,
matthewbauer and
piegamesde
as code owners
Artturin
force-pushed
the
splitfactoroutmeta
branch
from
178448e
to
e76089c
Compare
emilytrau
approved these changes
May 1, 2023
piegamesde
reviewed
May 1, 2023
Artturin
force-pushed
the
splitfactoroutmeta
branch
from
e76089c
to
6c91e9d
Compare
stdenv: check if separating commonMeta from assertValidity fixes laziness issue
```
error: cannot coerce null to a string
at /var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/mr-est/ofborg-evaluator-3/pkgs/development/coq-modules/coq-lsp/default.nix:34:60:
33| homepage = "https://github.com/ejgallego/coq-lsp";
34| changelog = "https://github.com/ejgallego/coq-lsp/blob/${defaultVersion}/CHANGES.md";
```
Artturin
force-pushed
the
splitfactoroutmeta
branch
from
6c91e9d
to
2ad68a7
Compare
piegamesde
approved these changes
May 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split out from #227914
Description of changes
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)