logo-ls: init at 1.3.7 #229230
Closed
logo-ls: init at 1.3.7 #229230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofborg
bot
added
8.has: package (new)
figsoda
reviewed
May 1, 2023
| changelog = "https://github.com/Yash-Handa/logo-ls/releases/tag/v${version}"; | ||
| license = licenses.mit; | ||
| maintainers = with maintainers; [ natsukium ]; | ||
| platforms = platforms.unix; |
There was a problem hiding this comment.
Suggested change
| platforms = platforms.unix; |
There was a problem hiding this comment.
Thanks for checking.
It is due to a filename conflict, as shown in this issue.
Yash-Handa/logo-ls#26
I will create a patch to fix it.
Comment on lines
+2
to
+3
| , fetchFromGitHub | ||
| , buildGoModule |
There was a problem hiding this comment.
Suggested change
| , fetchFromGitHub | |
| , buildGoModule | |
| , buildGoModule | |
| , fetchFromGitHub |
wegank
added
2.status: stale
stale
bot
removed
the
2.status: stale
wegank
added
the
2.status: stale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Modern ls command with vscode like File Icon and Git Integrations.
https://github.com/Yash-Handa/logo-ls
closes #229175
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)