-
-
Notifications
You must be signed in to change notification settings - Fork 14.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
apple_sdk: remove cf-private alias #229314
Merged
wegank
merged 1 commit into
NixOS:master
from
ConnorBaker:fix/apple-sdk-remove-cf-private
May 2, 2023
Merged
apple_sdk: remove cf-private alias #229314
wegank
merged 1 commit into
NixOS:master
from
ConnorBaker:fix/apple-sdk-remove-cf-private
May 2, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ConnorBaker
commented
May 1, 2023
@@ -1,6 +1,5 @@ | |||
{ lib, stdenv | |||
, fetchFromGitHub | |||
, unstableGitUpdater |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was unused in the derivation so I removed it as general cleanup.
12 tasks
Should this maybe throw a warning first before turning into a hard error? Also breaking changes are now restricted, see #223562 |
Let's only keep |
ofborg
bot
added
10.rebuild-darwin: 0
This PR does not cause any packages to rebuild on Darwin
10.rebuild-linux: 0
This PR does not cause any packages to rebuild on Linux
labels
May 1, 2023
ConnorBaker
force-pushed
the
fix/apple-sdk-remove-cf-private
branch
from
May 2, 2023 01:59
8770902
to
b2eb5c8
Compare
ofborg
bot
added
8.has: package (new)
This PR adds a new package
10.rebuild-darwin: 1-10
10.rebuild-darwin: 1
and removed
10.rebuild-darwin: 0
This PR does not cause any packages to rebuild on Darwin
labels
May 2, 2023
wegank
approved these changes
May 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
6.topic: darwin
Running or building packages on Darwin
8.has: package (new)
This PR adds a new package
10.rebuild-darwin: 1-10
10.rebuild-darwin: 1
10.rebuild-linux: 0
This PR does not cause any packages to rebuild on Linux
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Removed use of the
cf-private
alias todarwin.apple_sdk.frameworks.CoreFoundation
from Nixpkgs. Actual removal of thecf-private
attribute will be done later, after the 23.05 release: #229389.Things done
sandbox = true
set innix.conf
? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)