chromium: set TERM=dumb for ninja & chromium: do not skip {pre,post}Build #229367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 1, 2023 23:58
In pkgs/development/tools/build-managers/ninja/setup-hook.sh, `ninjaBuildPhase()` sets `TERM=dumb` for the invocation of `ninja` in order to get progress output even when running on a remote builder. Let's do the same here, since we don't use `ninjaBuildPhase()`.
When overriding `buildPhase` it is important to remember to explicitly call `runHook preBuild` and `runHook postBuild`. I forget to do this all the time.
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In pkgs/development/tools/build-managers/ninja/setup-hook.sh,
ninjaBuildPhase()setsTERM=dumbfor the invocation ofninjain order to get progress output even when running on a remote
builder. Let's do the same here, since we don't use
ninjaBuildPhase().###### Description of changesThings done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)