Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xdg-utils: unstable-2020-10-21 -> unstable-2022-11-06 #229556

Merged
merged 1 commit into from
May 18, 2023

Conversation

colemickens
Copy link
Member

Description of changes

I noticed a unstable-2020... in my build log so I grabbed this one too.

Updates xdg-utils to latest unstable, since they haven't tagged a release since 2018.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@Tungsten842
Copy link
Member

Duplicate of #228896

@Tungsten842 Tungsten842 marked this as a duplicate of #228896 May 3, 2023
@vcunat
Copy link
Member

vcunat commented May 3, 2023

The other PR seems much worse to me, though. The title and commit message, also targeting 22.11 (and even the channel branch).

@colemickens
Copy link
Member Author

I do think this PR looks "more correct", but either way. Might be a good chance to help guide a future new contributor too!

@colemickens colemickens mentioned this pull request May 4, 2023
12 tasks
@InLaw
Copy link
Contributor

InLaw commented May 4, 2023

I'm happy if there is progress .. (without people blocking it, due to reasons not everyone could understand easily regarding its tradeoff / officialdom)

@colemickens
Copy link
Member Author

I've been running with this for a few days without issue.

@vcunat vcunat changed the base branch from master to staging May 18, 2023 11:44
@vcunat vcunat merged commit 126457a into NixOS:staging May 18, 2023
@colemickens colemickens deleted the pr-xdg-utils branch October 3, 2023 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants