emscripten: 3.1.24 -> 3.1.39, binaryen: 112 -> 113 #229718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willcohen
force-pushed
the
emscripten-3.1.30
branch
from
6b70b81 to
4a909ce
Compare
willcohen
force-pushed
the
emscripten-3.1.30
branch
from
4a909ce to
727cf0e
Compare
|
We just merged LLVM16, you can drop the patch and use LLVM16 :). |
|
It does not have enough rebuilds to target staging, please target master! |
willcohen
force-pushed
the
emscripten-3.1.30
branch
from
727cf0e to
14dacfe
Compare
|
@RaitoBezarius re-targeted to master, and also got the new version up to 3.1.36. It's still on LLVM 15 with the patch for now, since LLVM 16 isn't quite building for me on my local aarch64 mac. It's quite possible once hydra gets through another round on the master branch that I can pull a built LLVM 16 from cache and get that resolved. |
|
@RaitoBezarius Per my comment in the llvm 17 thread, it looks like bumping to 16 isn't a smooth ride. It's possible that one of the 16 point releases will resolve some of the issues. I should note that emscripten's been on the LLVM 17.0.0 trunk since 3.1.31, so there's no reason to expect that 16 can/should necessarily work better than 15 at the moment. If it's okay with you, it seems like it'd be better to get this bumped to 3.1.36 using a patched LLVM 15 rather than having this stuck on a moderately-old 2022 emscripten release. Then, as I work on 3.1.37+, I'll see what else I need to back port from later 16 point releases or 17 trunk to get this working on 16/17. |
|
Unless you really want this bump quickly, I would try to go and upgrade our |
|
Result of 17 packages marked as broken and skipped:
9 packages failed to build:
21 packages built:
|
|
Makes sense. Will poke around. Besides, it's possible that this breaks zig as well, based on nixpkgs-review. |
This was referenced May 5, 2023
willcohen
force-pushed
the
emscripten-3.1.30
branch
from
14dacfe to
489e40c
Compare
willcohen
changed the title
Closed
|
nixpkgs-review is broken for me in general with the following error, which I believe is unrelated to this PR, but |
12 tasks
ofborg
bot
added
10.rebuild-linux: 501+
10.rebuild-linux: 5001+
and removed
10.rebuild-darwin: 11-100
10.rebuild-linux: 101-500
labels
|
Whoa. I assume that's from json-c. Moving to staging. |
|
@RaitoBezarius would it be preferable that i move the |
|
Result of 517 packages marked as broken and skipped:
1 package blacklisted:
117 packages failed to build:
35 packages built:
|
It's fine to keep it here IMHO, targeting staging is the good call. |
willcohen
force-pushed
the
emscripten-3.1.30
branch
from
b4d35b2 to
5d0918e
Compare
|
|
|
@RaitoBezarius I think this is ready for staging. (Results on master, where I can at least pull the prereqs from cache): |
|
I won't be able to look seriously right now as I will perform my release duties in the next 48 hours for 23.05. |
|
Of course, good luck! |
|
@RaitoBezarius small ping. if this still need to wait till the following week pending release stuff, that is of course fine too! |
|
Many thanks! |
Also on Hydra: |
Merged
12 tasks
|
OfBorg could build the source around a week ago, so apparently upstream changed it? |
|
Thank you for catching, I guess I'd been working on local pulls and hadn't noticed a change. Updated #235624 accordingly. |
vcunat
added a commit
that referenced
this pull request
Jun 5, 2023
This reverts commit 8392a8b. It's needed for emscripten revert; see the next commit.
vcunat
added a commit
that referenced
this pull request
Jun 5, 2023
This reverts commit 39d2924. Now it will at least fetch sources FIXME correctly and build on *-linux.
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)