[wip] create maintainers/categories-set.nix #230439
Conversation
ofborg
bot
added
10.rebuild-darwin: 0
|
I guess what is needed is also adding category to the meta attribute whitelist? |
|
Isn't this an ofborg-specific config? |
|
There is a list in the manual, and there is |
github-actions
bot
added
6.topic: lib
|
Here is the current listing of files inside pkgs directory. They can be useful for filling the categories set. |
|
@7c6f434c can you please check this again? |
doc/stdenv/meta.chapter.md
Outdated
| @@ -244,6 +244,10 @@ Unfree package that cannot be redistributed. You can build it yourself, but you | |||
|
|
|||
| This package supplies unfree, redistributable firmware. This is a separate value from `unfree-redistributable` because not everybody cares whether firmware is free. | |||
|
|
|||
| ## Categories {#sec-meta-categories} | |||
|
|
|||
| The categories of the package. A list of attributes from the attribute set defined in [`nixpkgs/lib/categories-set.nix`](https://github.com/NixOS/nixpkgs/blob/master/lib/categories-set.nix). | |||
There was a problem hiding this comment.
| The categories of the package. A list of attributes from the attribute set defined in [`nixpkgs/lib/categories-set.nix`](https://github.com/NixOS/nixpkgs/blob/master/lib/categories-set.nix). | |
| The `meta.categories` attribute contains the categories of the package. A list of attributes from the attribute set defined in [`nixpkgs/lib/categories-set.nix`](https://github.com/NixOS/nixpkgs/blob/master/lib/categories-set.nix). |
There was a problem hiding this comment.
I still think the attribute name should be made explicit like in other entries.
There was a problem hiding this comment.
Can you explain? I'm not understanding.
There was a problem hiding this comment.
Some sections are titled with exact (including capitalisation) name of the meta attribute. Some sections include the full name in the text near the beginning. Some do both.
The proposed section here does neither, thus my suggestion to add meta.categories into the text of the section.
|
@7c6f434c what do you think of the example of |
|
I think it works fine as an example, but it feels a bit weird to add specifically «assembler» and not «compiler» |
Well, the idea is that OK, assemblers are compilers in a broader sense; however, this would be a case for Also, it shows the basic ideas of the data structure. |
|
«assembler → compiler → development» maybe with the transitive «assembler → development» would look natural (with the implication that we don't fill everything, it is just a demonstration), or as you proposed initially «audio → audioVideo» and tag some minor sound processing application like |
|
I suggest, then, to never fill the "transitive closure" of every category, in the sense of e.g. |
|
Now it should work as a POC |
As a proof-of-concept for NixOS/rfcs#146
As a proof-of-concept for NixOS RFC 146 Double wip because it lacks the descriptions.
|
Speaking of base categories, one thing definitionally not covered by Freedesktop is «data assets» — fonts, themes, icon packs, game levels (e.g. when the core is built on Hydra and unpacking a gigabyte of 3D models has empty hydraPlatforms), and other things one doesn't launch from an application menu. |
wegank
added
2.status: stale
stale
bot
removed
the
2.status: stale
|
check-meta conflicted, closing. |
As a proof-of-concept for NixOS/rfcs#146
Description of changes
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)