Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

calamares-nixos-extensions: 0.3.11 -> 0.3.12 #230694

Merged
merged 1 commit into from
May 11, 2023

Conversation

vlinkz
Copy link
Member

@vlinkz vlinkz commented May 8, 2023

Description of changes
Things done
  • Update the calamares-nixos-extensions package to the latest version.
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels May 8, 2023
@bobby285271 bobby285271 requested a review from RaitoBezarius May 9, 2023 04:56
Copy link
Member

@bobby285271 bobby285271 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay I did an trivial installation and it sounds nice (well I believe this is tested by multiple users already 🙈)

Confirmed Budgie can be installed and the installed Budgie starts

Confirmed /boot is required as esp when doing manual partitioning

We really want to have budgie and deepin (well ideally we can have NixOS/calamares-nixos-extensions#20 as well) added as installation option in 23.05. I am not 100% sure if changing default esp can be accpected accepted during freeze, I do think just for fresh installations this should be fine 🤔 (If RMs don't respond I guess I will do the merge soon™)

@bobby285271 bobby285271 added this to the 23.05 milestone May 11, 2023
@mweinelt
Copy link
Member

I am not 100% sure if changing default esp can be accpected during #223562

Looks fine to me.

@mweinelt mweinelt merged commit 0bda75b into NixOS:master May 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

don't require special boot.loader.efi.efiSysMountPoint
3 participants