-
-
Notifications
You must be signed in to change notification settings - Fork 14.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tuxedo-rs: init at 0.2.2 #231384
tuxedo-rs: init at 0.2.2 #231384
Conversation
9851a42
to
9da8358
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please change the PR title from tuxedo-rs: intit at 0.2.1
to tuxedo-rs: init at 0.2.1
.
Please rebase and fix merge conflicts. Also personally I'd prefer to split "init" of the package and module into 2 commits. I am not sure about waht the consensus is on that. Therefore not "demanding" or "requiring" any change on that. Just putting it to the discussion here. |
I have rebased and split the tuxedo-rs init commit into separate package init and module init commits. |
cc6629d
to
f8b1d4c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I clone your branch, I can build both tailor_gui
and tuxedo-rs
without problems. But something is obviously wrong with the output paths here, I don't know what to do about it at the moment, someone with more experience should take a look at that.
Same here. |
It doesn't seem to like inherit ((lib.importTOML "${src}/tailord/Cargo.toml").package) version; and the use of |
Yes, in the output of nixpkgs-review it looks like it doesn't like that part. |
It seems like it also doesn't like cargoDeps = rustPlatform.importCargoLock {
lockFile = src + "/Cargo.lock";
}; if The latest changes are working on my local machine (tested with |
🙏 |
# x86_64-linux
> nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
2 packages added:
tailor_gui tuxedo-rs (init at 0.2.1)
1 package updated:
nixos-install-tools
1 package blacklisted:
nixos-install-tools
2 packages built:
tailor-gui tuxedo-rs
|
added platforms to meta |
Updated |
Updated from |
Description of changes
This adds tuxedo-rs, which consists of:
tuxedo-rs is an alternative to the TUXEDO Control Center (TCC), for which there exists a packaging request: #132206.
Note that if the packaging request for TCC is fulfilled, the daemons will conflict with each other, so the respective modules should ensure that the other one is disabled.
I had previously contributed a flake to tuxedo-rs, on which I have based this PR - with a small change to the module (
options.services
->options.hardware
).If this is merged, I plan to rewrite the module in the flake to use this one and override the package
src
.I have been using the tuxedo-rs module on my device for a few weeks now.
Things done
sandbox = true
set innix.conf
? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)