Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mlterm: disable fb gui due to mlconfig tool issue #232706

Merged
merged 1 commit into from
May 19, 2023
Merged

mlterm: disable fb gui due to mlconfig tool issue #232706

merged 1 commit into from
May 19, 2023

Conversation

doronbehar
Copy link
Contributor

Motivation for this change

Follow up to #226218 . Motivation explained in the comment added.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@doronbehar doronbehar mentioned this pull request May 18, 2023
Merged
13 tasks
@ofborg ofborg bot requested a review from Atemu May 18, 2023 23:14
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels May 18, 2023
Atemu
Atemu approved these changes May 19, 2023
View reviewed changes
Copy link
Member

@Atemu Atemu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Small nit: mlterm: Disable fb gui due to mlconfig tool issue -> mlterm: disable fb gui due to mlconfig tool issue

@doronbehar doronbehar changed the title mlterm: Disable fb gui due to mlconfig tool issue mlterm: disable fb gui due to mlconfig tool issue May 19, 2023
@ofborg ofborg bot requested a review from Atemu May 19, 2023 13:45
Atemu
Atemu approved these changes May 19, 2023
View reviewed changes
Copy link
Member

@Atemu Atemu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Result of nixpkgs-review pr 232706 run on x86_64-linux 1

2 packages built:
  • mlterm
  • mlterm-wayland

@Atemu Atemu merged commit 8f50bc7 into NixOS:master May 19, 2023
@doronbehar doronbehar deleted the pkg/mlterm-fb branch June 8, 2024 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Atemu Atemu Atemu approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@doronbehar @Atemu