Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crowdin-cli: 3.11.0 -> 3.11.1 #233194

Closed
wants to merge 1 commit into from
Closed

Conversation

pbek
Copy link
Contributor

@pbek pbek commented May 21, 2023

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@pbek
Copy link
Contributor Author

pbek commented May 21, 2023

Result of nixpkgs-review pr 233194 run on x86_64-linux 1

1 package built:
  • crowdin-cli

@pbek pbek marked this pull request as ready for review May 21, 2023 10:00
@pbek
Copy link
Contributor Author

pbek commented May 21, 2023

Binary works fine for me.

@pbek pbek requested a review from DamienCassou May 21, 2023 10:01
@pbek
Copy link
Contributor Author

pbek commented May 21, 2023

@ofborg eval

@pbek
Copy link
Contributor Author

pbek commented May 21, 2023

Meh, wrong branch 😅 Sorry

@pbek pbek closed this May 21, 2023
@pbek
Copy link
Contributor Author

pbek commented May 21, 2023

closed in favor of #233201

@pbek pbek deleted the patch-11 branch May 21, 2023 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant