Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release notes: Mention the Nix update in 23.05 #233975

Closed
wants to merge 3 commits into from

Conversation

thufschmitt
Copy link
Member

Links to the corresponding release notes, and mentions NixOS/nix#8259 which isn't included in it (and is somewhat important since it's a language semantics change)

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Links to the corresponding release notes, and mentions NixOS/nix#8259 which isn't included in it (and is somewhat important since it's a language semantics change)
@thufschmitt thufschmitt changed the title release notes: Mention the Nix update in 22.03 release notes: Mention the Nix update in 23.05 May 25, 2023
@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: changelog 8.has: documentation This PR adds or changes documentation labels May 25, 2023
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels May 25, 2023
@RaitoBezarius RaitoBezarius requested a review from mweinelt May 25, 2023 12:11
Copy link
Member

@RaitoBezarius RaitoBezarius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@fricklerhandwerk
Copy link
Contributor

Fixed conflicts and re-ordered the notes such that those core components appear first.

@@ -12,13 +12,16 @@ To upgrade to the latest release, follow the [upgrade chapter](https://nixos.org

In addition to numerous new and updated packages, this release has the following highlights:

- default Nix: 2.11 -\> 2.13. This includes in particular a [small language change](https://github.com/NixOS/nix/issues/8259) altering the way floats are represented in `builtins.toJSON`.
See the release notes for [2.13](https://nixos.org/manual/nix/stable/release-notes/rl-2.13.html) and [2.14](https://nixos.org/manual/nix/stable/release-notes/rl-2.14.html) for more info.
Copy link
Member

@mweinelt mweinelt May 31, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The 2.14 release notes are 404. Who do I have to contact to get this fixed.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We went with the unstable manual, but please remember to also update stable when you can.

@mweinelt
Copy link
Member

Included in #235183. Thanks for the reminder.

@mweinelt mweinelt closed this May 31, 2023
@SuperSandro2000 SuperSandro2000 deleted the mention-nix-in-2203-release-notes branch June 16, 2023 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: changelog 8.has: documentation This PR adds or changes documentation 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants